[wpt-sync] Sync PR 43243 - [a11y] Move some of serialization pipeline from RAI to cache.
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox122 fixed)
Tracking | Status | |
---|---|---|
firefox122 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 43243 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/43243
Details from upstream follow.
Ahmed Elwasefi <a.m.elwasefi@gmail.com> wrote:
[a11y] Move some of serialization pipeline from RAI to cache.
This CL aims to start moving some of the codepath starting from HandleAXEvent to ScheduleImmediateAXUpdate over to cache side. The old code is still left in RAI for legacy support.
The aim is to eventually delete the code from RAI side and then RAI would only be called from ProcessDeferredAccessibilityEvents to AXReadyCallback.
This image shows the interactions between AXObjectCache and RenderAccessoibiltyImpl before this CL: https://i.imgur.com/c5RlA2B.png
What the CL achieves is moving the code in the blue square over to the left-hand side, thus making the code stay in AXObjectCache longer and only move to RAI at RenderAccessibilityImpl::AXReadyCallback. The serialization delay is moved to ProcessDeferredAccessibilityEvents.Legacy mode still uses the old code which goes back and forth between RAI and AXObjectCache. The reason they were not moved as well is that legacy mode will get removed eventually anyway. When legacy mode is removed, we can safely remove the old code from RAI.
Also, with the cleaner code, it'll be feasible to change the scheduling logic further to limit some events like scrolling. Scrolling improvements discussed here https://docs.google.com/document/d/1fBK1BBrG8souqZpyv7q_3kxCYF1IYoXNPXmoVL7X8Gk/edit#heading=h.uo8ebdp7cxl
Change-Id: I4662c29ee0185b8554b80b71db5ffb0aa6fc2319
Reviewed-on: https://chromium-review.googlesource.com/4994320
WPT-Export-Revision: 6ed3588b7a19e98068b01ddc9c8558c50151f886
Assignee | ||
Comment 1•7 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3fffe54f58209c6aea800746e313d3467133d0d
Assignee | ||
Comment 2•7 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1cc4509d0114b53f013971622b9fa8a7745b3d9
Assignee | ||
Comment 3•7 months ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 5 subtests
Status Summary
Firefox
ERROR
: 1
Chrome
OK
: 1
PASS
: 4
FAIL
: 1
Safari
ERROR
: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /long-animation-frame/tentative/loaf-desired-exec-time.html [wpt.fyi]:
ERROR
(Chrome:OK
, Safari:ERROR
)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13c3b89d46a1 [wpt PR 43243] - [a11y] Move some of serialization pipeline from RAI to cache., a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0143bb81e703 [wpt PR 43243] - [a11y] Move some of serialization pipeline from RAI to cache., a=testonly
Comment 6•7 months ago
|
||
bugherder |
Description
•