1865525 - OpenPGP code adds listeners for (un)load-enigmail which never gets triggerd

Status: RESOLVED WORKSFORME

(MailNews Core :: Security: OpenPGP, defect)

Description

[Mark Banner (:standard8)]

See here:

https://searchfox.org/comm-central/search?q=load-enigmail&path=&case=false&regexp=false

These listeners are never triggered.

It appears loading has been re-implemented here: https://searchfox.org/comm-central/rev/633ee6c78a827657a30a670a78d350ea7e381274/mail/base/content/aboutMessage.js#93-94

It is unclear if unloading is properly re-implemented or still needed.

For example onUnloadEnigmail is no longer called: https://searchfox.org/comm-central/rev/633ee6c78a827657a30a670a78d350ea7e381274/mail/extensions/openpgp/content/ui/enigmailMessengerOverlay.js#2642-2679

Although messageClose is: https://hg.mozilla.org/comm-central/log/tip/mail/extensions/openpgp/content/ui/enigmailMessengerOverlay.js

This is probably a regression from bug 1799764 which implemented the handling in the new layout, but didn't clean up the existing parts.

Either way, it is tech debt as it is confusing how the Enigmail module is actually getting initialised.

Comment 1

[Geoff Lankow (:darktrojan)]

They were unused before I went near it. Here's the same query in esr91. (Agree though, this is untidy.)

Comment 2

[Magnus Melin [:mkmelin]]

This has been cleaned out.