1865570 - [loong64][mips64] Failed to build loong64 and mips64 simulator (error: no member named 'Args_Int32_GeneralInt64Int64Int64GeneralGeneral' in namespace 'js::jit')

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect)

Description

[Zhao Jiazhong]

Bug 1861267 updated a function prototype in simulators, which should be ported to loong64 and mips64 platform. Otherwise, fail to build js simulator for loong64 and mips64:

js/src/jit/loong64/Simulator-loong64.cpp:2861:21: error: no member named 'Args_Int32_GeneralInt64Int64Int64GeneralGeneral' in namespace 'js::jit'; did you mean 'Args_Int32_GeneralInt64Int64Int64General'?

Comment 1

[Zhao Jiazhong]

Attachment: Bug 1865570 - [loong64][mips64] Update a function prototype in simulator. r=jseward

Port D193527 to loong64 and mips64 platform.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7ce1a446e6a
[loong64][mips64] Update a function prototype in simulator. r=jseward DONTBUILD

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b7ce1a446e6a

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1861267

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:zhaojiazhong-hf, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Zhao Jiazhong]

Since it only affects simulator, I think it's ok not to uplift it.
But I'm not clear how to set status-firefox121 to wontfix.

Comment 7

[Donal Meehan [:dmeehan]]

(In reply to Zhao Jiazhong from comment #6)

Since it only affects simulator, I think it's ok not to uplift it.
But I'm not clear how to set status-firefox121 to wontfix.

Removed the tracking request, and set 121 to wontfix

Comment 8

[Zhao Jiazhong]

(In reply to Donal Meehan [:dmeehan] from comment #7)

Removed the tracking request, and set 121 to wontfix

Thanks for your reply, but may be it needs some kind of permission? I did't find the wontfix option in Status.

Comment 9

[Donal Meehan [:dmeehan]]

(In reply to Zhao Jiazhong from comment #8)

Thanks for your reply, but may be it needs some kind of permission? I did't find the wontfix option in Status.

Correct, it's edit permissions. not everything is available.
Thanks again for Comment 6