Closed Bug 1865583 Opened 1 years ago Closed 1 year ago

[wpt-sync] Sync PR 43251 - Unload: post close message on pagehide instead of unload

Categories

(Core :: DOM: Device Interfaces, task, P4)

Product:
Core
Component:
DOM: Device Interfaces
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43251 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43251
Details from upstream follow.

Mingyu Lei <leimy@chromium.org> wrote:

Unload: post close message on pagehide instead of unload

These three tests fails because it depends on the "close" message
sent from unload handler. This CL changes it to pagehide handler so
it would be triggered as expected even after unload is deprecated.

Bug: 1488371
Change-Id: I754d38b5997bd6a01ba512f17d434cd260f7801d
Reviewed-on: https://chromium-review.googlesource.com/5043665
WPT-Export-Revision: 642d7029511f4a90d219aabbcb506055d1f838f2

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
PASS: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /battery-status/no-leak-on-detached-use.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • navigator.getBattery() does not operate on a closed window: FAIL (Chrome: PASS, Safari: FAIL)
    • navigator.getBattery() on a detached frame does not leak or crash: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /battery-status/no-leak-on-detached-use.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d6e55d56f5a [wpt PR 43251] - Unload: post close message on pagehide instead of unload, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9d15737010d [wpt PR 43251] - Unload: post close message on pagehide instead of unload, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e9d15737010d

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.