1865591 - 1.37 - 1.02% apk-size-fenixDebug / apk-size-fenixDebug (Android) regression on Wed November 8 2023

Status: RESOLVED WONTFIX

(Fenix :: Homepage, defect, P2)

Description

[Alex Finder]

Perfherder has detected a build_metrics performance regression from push 9d916549240b3361bea5e395d054880f824b7abd. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	apk-size-fenixDebug	fenix-android-all		121,507,146.17 -> 123,171,514.50
1%	apk-size-fenixDebug	fenix-android-all		121,360,673.00 -> 122,602,769.25

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Chris Peterson [:cpeterson]]

(In reply to Alex Finder from comment #0)

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	apk-size-fenixDebug	fenix-android-all		121,507,146.17 -> 123,171,514.50
1%	apk-size-fenixDebug	fenix-android-all		121,360,673.00 -> 122,602,769.25

121,507,146.17 -> 123,171,514.50 = ~1625 KB

Tom, did you expect the new favicons increased the debug APK size by 1625 KB?? Are the new favicons bigger than the old ones? Did you remove the old ones?

Comment 2

[Joe M [:jmahon]]

FYI for viewers: (1) Tom is OOO this week, and (2) Bug 1821701 included adding a new library to manage favicon rendering. I presume that accounts for the diff, but am waiting for someone to consult in this thread before asserting that with certainty here.

If that's the case, and this APK size diff was taken into account when the team validated the inclusion of the Coil library in the first place, then I presume this will get closed as a WONTFIX - but I'll hold off doing so until someone validates that with more confidence :)

Comment 3

[Zac McKenney [:zmckenney]]

This is a Debug alert which are now disabled by Bug 1864753. With R8 the resulting size of this change is actually around 300 KB. Closing this as a WONTFIX.

I ran 2 local Fenix Nightly builds. One with updated main branch and one with 9d916549240b3361bea5e395d054880f824b7abd reverted. I'm not seeing the large increase from this revision and it aligns with what I expect the Coil dependency size increase to be.

app-fenix-arm64-v87a-nightly.apk

With Coil: 100.7 MB
Without Coil: 100.4 MB