1.66% apk-size-fenixNightly (Android) regression on Thu November 9 2023
Categories
(GeckoView :: General, defect, P2)
Tracking
(firefox120 unaffected, firefox121 wontfix, firefox122 wontfix)
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | unaffected |
| firefox121 | --- | wontfix |
| firefox122 | --- | wontfix |
People
(Reporter: afinder, Unassigned)
References
(Regression)
Details
(Keywords: perf-alert, regression)
Perfherder has detected a build_metrics performance regression from push f1fb5f0afb5896b5c30e6a9b1439a9c4de4a3db2. As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 2% | apk-size-fenixNightly | fenix-android-all | 98,372,643.33 -> 100,005,953.67 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.
For more information on performance sheriffing please see our FAQ.
|
||
Comment 1•2 years ago
|
||
(In reply to Alex Finder from comment #0)
Regressions:
Ratio Test Platform Options Absolute values (old vs new) 2% apk-size-fenixNightly fenix-android-all 98,372,643.33 -> 100,005,953.67
98,372,643.33 -> 100,005,953.67 = 1595 KB
Jamie, is 1.5 MB about the expected APK size increase we expected from PGO bug 1663700? Should we resolve this bug as WONTFIX?
|
||
Updated•2 years ago
|
|
||
Comment 2•2 years ago
|
||
That seems about right, perhaps slightly higher than I expected. I was seeing ~1.1MB for the aarch64 geckoview_example pushes I did. What architecture is the above alert tracking?
Even at 1.5MB I'd say the benefit more than outweighs the cost
|
|
||
Comment 3•2 years ago
|
||
(In reply to Jamie Nicol [:jnicol] from comment #2)
That seems about right, perhaps slightly higher than I expected. I was seeing ~1.1MB for the aarch64 geckoview_example pushes I did. What architecture is the above alert tracking?
I don't know which architecture(s) "apk-size-fenixNightly opt" is the same as "apk-size-fenixNightly app-fenix-arm64-v8a-nightly-unsigned.apk opt".
Even at 1.5MB I'd say the benefit more than outweighs the cost
SGTM. In that case, I'll resolve this bug as WONTFIX.
Description
•