1865618 - Support "undefined" and "null" for "viewport" argument of "browsingContext.setViewport" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The WebDriver BiDi spec has recently been changed to support undefined and null for the viewport argument. Tests have been updated as part of bug 1860770 which will sync hopefully soon.

We should update that code before starting with the implementation of the support for devicePixelRatio on bug 1857961.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1865618 - [wdspec] Rename test module set_viewport.py to viewport.py.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1865618 - [wdspec] Update "browsingContext.setViewport" tests for invalid "devicePixelRatio" tests.

Tests were not failing as expected because of the missing "viewport"
argument.

Depends on D194544

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null" and "undefined".

Depends on D194545

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1865618 - [wdspec] Improve "browsingContext.setViewport" tests to trigger reflows.

Without an actual page loaded, changing the viewport will not trigger
any reflow and as such doesn't test real use-case scenarios.

Depends on D194546

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65228ad8a272
[wdspec] Rename test module set_viewport.py to viewport.py. r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/a9f154bc28c7
[wdspec] Update "browsingContext.setViewport" tests for invalid "devicePixelRatio" tests. r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/36f0fa2e8791
[webdriver-bidi] Allow "viewport" to be "null" and "undefined". r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/988211aadb0d
[wdspec] Improve "browsingContext.setViewport" tests to trigger reflows. r=webdriver-reviewers,Sasha

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43342 for changes under testing/web-platform/tests

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/65228ad8a272
https://hg.mozilla.org/mozilla-central/rev/a9f154bc28c7
https://hg.mozilla.org/mozilla-central/rev/36f0fa2e8791
https://hg.mozilla.org/mozilla-central/rev/988211aadb0d

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot