Closed Bug 1865618 Opened 3 months ago Closed 3 months ago

Support "undefined" and "null" for "viewport" argument of "browsingContext.setViewport" command

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

task
Points:
2

Tracking

(firefox122 fixed)

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [webdriver:m9], [wptsync upstream][webdriver:relnote])

Attachments

(4 files)

The WebDriver BiDi spec has recently been changed to support undefined and null for the viewport argument. Tests have been updated as part of bug 1860770 which will sync hopefully soon.

We should update that code before starting with the implementation of the support for devicePixelRatio on bug 1857961.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED

Tests were not failing as expected because of the missing "viewport"
argument.

Depends on D194544

Points: --- → 2
Priority: -- → P1
Whiteboard: [webdriver:m9]
Attachment #9365234 - Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "undefined".
Attachment #9365234 - Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "undefined". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null".
Attachment #9365234 - Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null" and "undefined".
Attachment #9365234 - Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null" and "undefined". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null".
Attachment #9365234 - Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null" and "undefined".

Without an actual page loaded, changing the viewport will not trigger
any reflow and as such doesn't test real use-case scenarios.

Depends on D194546

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65228ad8a272
[wdspec] Rename test module set_viewport.py to viewport.py. r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/a9f154bc28c7
[wdspec] Update "browsingContext.setViewport" tests for invalid "devicePixelRatio" tests. r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/36f0fa2e8791
[webdriver-bidi] Allow "viewport" to be "null" and "undefined". r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/988211aadb0d
[wdspec] Improve "browsingContext.setViewport" tests to trigger reflows. r=webdriver-reviewers,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43342 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m9] → [webdriver:m9], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m9], [wptsync upstream] → [webdriver:m9], [wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.