Closed
Bug 1865618
Opened 10 months ago
Closed 10 months ago
Support "undefined" and "null" for "viewport" argument of "browsingContext.setViewport" command
Categories
(Remote Protocol :: WebDriver BiDi, task, P1)
Remote Protocol
WebDriver BiDi
Tracking
(firefox122 fixed)
RESOLVED
FIXED
122 Branch
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [webdriver:m9], [wptsync upstream][webdriver:relnote])
Attachments
(4 files)
The WebDriver BiDi spec has recently been changed to support undefined and null for the viewport argument. Tests have been updated as part of bug 1860770 which will sync hopefully soon.
We should update that code before starting with the implementation of the support for devicePixelRatio on bug 1857961.
|
Assignee | |
Comment 1•10 months ago
|
||
|
||
Updated•10 months ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 months ago
|
||
Tests were not failing as expected because of the missing "viewport"
argument.
Depends on D194544
|
|
Assignee | |
Updated•10 months ago
|
Points: --- → 2
Priority: -- → P1
Whiteboard: [webdriver:m9]
|
|
||
Updated•10 months ago
|
Attachment #9365234 -
Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "undefined".
|
|
||
Updated•10 months ago
|
Attachment #9365234 -
Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "undefined". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null".
|
|
||
Updated•10 months ago
|
Attachment #9365234 -
Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null" and "undefined".
|
|
||
Updated•10 months ago
|
Attachment #9365234 -
Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null" and "undefined". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null".
|
|
||
Updated•10 months ago
|
Attachment #9365234 -
Attachment description: Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null". → Bug 1865618 - [webdriver-bidi] Allow "viewport" to be "null" and "undefined".
|
|
Assignee | |
Comment 4•10 months ago
|
||
Without an actual page loaded, changing the viewport will not trigger
any reflow and as such doesn't test real use-case scenarios.
Depends on D194546
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65228ad8a272 [wdspec] Rename test module set_viewport.py to viewport.py. r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/a9f154bc28c7 [wdspec] Update "browsingContext.setViewport" tests for invalid "devicePixelRatio" tests. r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/36f0fa2e8791 [webdriver-bidi] Allow "viewport" to be "null" and "undefined". r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/988211aadb0d [wdspec] Improve "browsingContext.setViewport" tests to trigger reflows. r=webdriver-reviewers,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43342 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m9] → [webdriver:m9], [wptsync upstream]
|
||
Comment 7•10 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/65228ad8a272
https://hg.mozilla.org/mozilla-central/rev/a9f154bc28c7
https://hg.mozilla.org/mozilla-central/rev/36f0fa2e8791
https://hg.mozilla.org/mozilla-central/rev/988211aadb0d
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
Upstream PR merged by moz-wptsync-bot
|
|
Assignee | |
Updated•8 months ago
|
Whiteboard: [webdriver:m9], [wptsync upstream] → [webdriver:m9], [wptsync upstream][webdriver:relnote]
You need to log in
before you can comment on or make changes to this bug.
Description
•