Closed Bug 1865636 Opened 2 years ago Closed 2 years ago

Perma [Tier 2] /builds/worker/checkouts/gecko/widget/windows/WinRegistry.cpp:287:3: error: no matching function for call to 'RegisterWaitForSingleObject'

Categories

(Firefox Build System :: General, defect, P5)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(firefox-esr115 unaffected, firefox120 unaffected, firefox121 unaffected, firefox122 fixed)

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox120 --- unaffected
firefox121 --- unaffected
firefox122 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: emilio)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1865636 - Move WinRegistry::KeyWatcher watch callback out of line. r=#win-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=436858888&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GiiBaYldTHKR2Ci04iUrqQ/runs/0/artifacts/public/logs/live_backing.log

INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/nsAppShell.h:12:
[task 2023-11-20T13:42:01.935Z] 13:42:01     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/TimeStamp.h:27:
[task 2023-11-20T13:42:01.935Z] 13:42:01  WARNING -  /builds/worker/workspace/obj-build/dist/include/mozilla/TimeStamp_windows.h:53:13: warning: 'dllimport' attribute ignored on inline function [-Wignored-attributes]
[task 2023-11-20T13:42:01.935Z] 13:42:01     INFO -     53 |   constexpr MFBT_API TimeStampValue(uint64_t aGTC, uint64_t aQPC, bool aHasQPC)
[task 2023-11-20T13:42:01.935Z] 13:42:01     INFO -        |             ^
[task 2023-11-20T13:42:01.936Z] 13:42:01     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:101:24: note: expanded from macro 'MFBT_API'
[task 2023-11-20T13:42:01.936Z] 13:42:01     INFO -    101 | #      define MFBT_API MOZ_IMPORT_API
[task 2023-11-20T13:42:01.936Z] 13:42:01     INFO -        |                        ^
[task 2023-11-20T13:42:01.936Z] 13:42:01     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:63:39: note: expanded from macro 'MOZ_IMPORT_API'
[task 2023-11-20T13:42:01.936Z] 13:42:01     INFO -     63 | #    define MOZ_IMPORT_API __declspec(dllimport)
[task 2023-11-20T13:42:01.936Z] 13:42:01     INFO -        |                                       ^
[task 2023-11-20T13:42:01.936Z] 13:42:01     INFO -  In file included from Unified_cpp_widget_windows1.cpp:2:
[task 2023-11-20T13:42:01.937Z] 13:42:01     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/TaskbarTabPreview.cpp:8:
[task 2023-11-20T13:42:01.937Z] 13:42:01     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/TaskbarTabPreview.h:12:
[task 2023-11-20T13:42:01.937Z] 13:42:01     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/TaskbarPreview.h:21:
[task 2023-11-20T13:42:01.937Z] 13:42:01     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/WindowHook.h:16:
[task 2023-11-20T13:42:01.937Z] 13:42:01     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/nsAppShell.h:12:
[task 2023-11-20T13:42:01.937Z] 13:42:01     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/TimeStamp.h:27:
[task 2023-11-20T13:42:01.938Z] 13:42:01  WARNING -  /builds/worker/workspace/obj-build/dist/include/mozilla/TimeStamp_windows.h:62:26: warning: 'dllimport' attribute ignored on inline function [-Wignored-attributes]
[task 2023-11-20T13:42:01.938Z] 13:42:01     INFO -     62 |   constexpr MOZ_IMPLICIT MFBT_API TimeStampValue(uint64_t aGTCAndQPC)
[task 2023-11-20T13:42:01.938Z] 13:42:01     INFO -        |                          ^
[task 2023-11-20T13:42:01.938Z] 13:42:01     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:101:24: note: expanded from macro 'MFBT_API'
[task 2023-11-20T13:42:01.938Z] 13:42:01     INFO -    101 | #      define MFBT_API MOZ_IMPORT_API
[task 2023-11-20T13:42:01.938Z] 13:42:01     INFO -        |                        ^
[task 2023-11-20T13:42:01.939Z] 13:42:01     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:63:39: note: expanded from macro 'MOZ_IMPORT_API'
[task 2023-11-20T13:42:01.939Z] 13:42:01     INFO -     63 | #    define MOZ_IMPORT_API __declspec(dllimport)
[task 2023-11-20T13:42:01.939Z] 13:42:01     INFO -        |                                       ^
[task 2023-11-20T13:42:01.939Z] 13:42:01     INFO -  In file included from Unified_cpp_widget_windows1.cpp:2:
[task 2023-11-20T13:42:01.939Z] 13:42:01     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/TaskbarTabPreview.cpp:8:
[task 2023-11-20T13:42:01.940Z] 13:42:01     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/TaskbarTabPreview.h:12:
[task 2023-11-20T13:42:01.940Z] 13:42:01     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/TaskbarPreview.h:21:
[task 2023-11-20T13:42:01.940Z] 13:42:01     INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/WindowHook.h:16:
[task 2023-11-20T13:42:01.940Z] 13:42:01  WARNING -  /builds/worker/checkouts/gecko/widget/windows/nsAppShell.h:33:8: warning: 'DoProcessMoreGeckoEvents' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
[task 2023-11-20T13:42:01.940Z] 13:42:01     INFO -     33 |   void DoProcessMoreGeckoEvents();
<....>
INFO -  In file included from /builds/worker/checkouts/gecko/widget/windows/nsWindowDbg.h:14:
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/BaseProfilerMarkersPrerequisites.h:30:
[task 2023-11-20T13:42:01.956Z] 13:42:01  WARNING -  /builds/worker/workspace/obj-build/dist/include/mozilla/BaseProfilerState.h:284:17: warning: 'dllimport' attribute ignored on inline function [-Wignored-attributes]
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -    284 |   [[nodiscard]] MFBT_API static mozilla::Maybe<uint32_t> FeaturesIfActive() {
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -        |                 ^
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:101:24: note: expanded from macro 'MFBT_API'
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -    101 | #      define MFBT_API MOZ_IMPORT_API
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -        |                        ^
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/Types.h:63:39: note: expanded from macro 'MOZ_IMPORT_API'
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -     63 | #    define MOZ_IMPORT_API __declspec(dllimport)
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -        |                                       ^
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -  In file included from Unified_cpp_widget_windows1.cpp:65:
[task 2023-11-20T13:42:01.956Z] 13:42:01    ERROR -  /builds/worker/checkouts/gecko/widget/windows/WinRegistry.cpp:287:3: error: no matching function for call to 'RegisterWaitForSingleObject'
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -    287 |   RegisterWaitForSingleObject(
[task 2023-11-20T13:42:01.956Z] 13:42:01     INFO -        |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  /builds/worker/fetches/clang/bin/../i686-w64-mingw32/include/winbase.h:2730:29: note: candidate function not viable: no known conversion from '(lambda at /builds/worker/checkouts/gecko/widget/windows/WinRegistry.cpp:289:7)' to 'WAITORTIMERCALLBACK' (aka 'void (*)(void *, unsigned char) __attribute__((stdcall))') for 3rd argument
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -   2730 |   WINBASEAPI WINBOOL WINAPI RegisterWaitForSingleObject (PHANDLE phNewWaitObject, HANDLE hObject, WAITORTIMERCALLBACK Callback, PVOID Context, ULONG dwMilliseconds, ULONG dwFlags);
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -        |                             ^                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  13 warnings and 1 error generated.
[task 2023-11-20T13:42:01.957Z] 13:42:01    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:688: Unified_cpp_widget_windows1.o] Error 1
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/widget/windows'
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2023-11-20T13:42:01.957Z] 13:42:01    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: widget/windows/target-objects] Error 2
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/crashreporter/google-breakpad/src/processor'
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  mkdir -p '.deps/'
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/crashreporter/google-breakpad/src/processor'
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/crashreporter/google-breakpad/src/processor'
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  toolkit/crashreporter/google-breakpad/src/processor/ia32_invariant.o
[task 2023-11-20T13:42:01.957Z] 13:42:01     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/crashreporter/google-breakpad/src/processor'
[task 2023-11-20T13:42:01.983Z] 13:42:01     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/maintenanceservice'
[task 2023-11-20T13:42:01.985Z] 13:42:01     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/i686-w64-mingw32-clang++ -o workmonitor.o -c  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DUNICODE -D_UNICODE -DNS_NO_XPCOM -I/builds/worker/checkouts/gecko/toolkit/components/maintenanceservice -I/builds/worker/workspace/obj-build/toolkit/components/maintenanceservice -I/builds/worker/checkouts/gecko/toolkit/mozapps/update/common -I/builds/worker/checkouts/gecko/toolkit/xre -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -fno-sized-deallocation -fno-aligned-new -fms-extensions -fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -fno-exceptions -Wno-incompatible-ms-struct -mstackrealign -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/workmonitor.o.pp   /builds/worker/checkouts/gecko/toolkit/components/maintenanceservice/workmonitor.cpp
[task 2023-11-20T13:42:01.986Z] 13:42:01     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/maintenanceservice'
[task 2023-11-20T13:42:01.987Z] 13:42:01     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/maintenanceservice'
[task 2023-11-20T13:42:01.987Z] 13:42:01     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/maintenanceservice'
[task 2023-11-20T13:42:01.992Z] 13:42:01     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/crashreporter/client'
[task 2023-11-20T13:42:01.995Z] 13:42:01     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/i686-w64-mingw32-clang++ -o crash_report_sender.o -c  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DUNICODE -D_UNICODE '-DBIN_SUFFIX=".exe"' -DNO_STABS_SUPPORT -I/builds/worker/checkouts/gecko/toolkit/crashreporter/client -I/builds/worker/workspace/obj-build/toolkit/crashreporter/client -I/builds/worker/checkouts/gecko/toolkit/components/jsoncpp/include -I/builds/worker/checkouts/gecko/toolkit/crashreporter/breakpad-client -I/builds/worker/checkouts/gecko/toolkit/crashreporter/google-breakpad/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -fno-sized-deallocation -fno-aligned-new -fms-extensions -fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -fno-exceptions -Wno-incompatible-ms-struct -mstackrealign -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -Wno-unused-local-typedefs -Wno-deprecated-declarations -Wno-bool-compare -Wno-unused-but-set-variable -Wno-c++11-narrowing -Wno-implicit-fallthrough -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/crash_report_sender.o.pp   /builds/worker/checkouts/gecko/toolkit/crashreporter/breakpad-client/windows/sender/crash_report_sender.cc
[task 2023-11-20T13:42:01.995Z] 13:42:01     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/crashreporter/client'
[task 2023-11-20T13:42:01.996Z] 13:42:01     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/crashreporter/minidump-analyzer'
[task 2023-11-20T13:42:01.996Z] 13:42:01     INFO -  mkdir -p '.deps/'
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Flags: needinfo?(emilio)

In order to fix MinGW32 builds, which can't cope with the pointer
conversion to stdcall apparently?

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9828830057c5 Move WinRegistry::KeyWatcher watch callback out of line. r=win-reviewers,handyman

https://hg.mozilla.org/mozilla-central/rev/9828830057c5

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch

Set release status flags based on info from the regressing bug 1825241

status-firefox120: --- → unaffected
status-firefox121: --- → unaffected
status-firefox-esr115: --- → unaffected
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: