Closed
Bug 186564
Opened 22 years ago
Closed 22 years ago
enable nsIStringService
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file)
|
7.65 KB,
patch
|
alecf
:
superreview+
|
Details | Diff | Splinter Review |
| Assignee | ||
Comment 1•22 years ago
|
||
this doesn't include the glue code for supporting NS_GetStringService. Also, NS_GetStringService will always create a new string service object - since this object doesn't have any state, it is okay just bad style. I am not sure we want to make this public.
Comment 2•22 years ago
|
||
doesn't nsEmbedString make this service obsolete?
| Assignee | ||
Comment 3•22 years ago
|
||
right. but then you would have to link in the glue code - or at least the nsEmbedString code. There are clients that don't want to carry any baggage.
Comment 4•22 years ago
|
||
ah, ic. well, the code looks fine to me for what its worth.
Comment 5•22 years ago
|
||
Comment on attachment 110009 [details] [diff] [review] enables nsStringService in build sure, me too. sr=alecf
Attachment #110009 -
Flags: superreview+
| Assignee | ||
Comment 6•22 years ago
|
||
although support for this is not 100% (ie this isn't a frozen interface), i have enabled this interface. for 1.3b. marking fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•