1865640 - Grab WorkerRef in StartConsuming instead of Create

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

It makes no sense to grab WorkerRef when Create() doesn't do anything. WorkerRef is only needed after StartConsuming happens where AsyncWait() is called.

(It's not so obvious who owns this class right now; my current plan is to replace almost every stream setup in this class with stream helpers and give it back to whoever maintains Fetch. For that reason I put this in DOM: Networking.)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1865640 - Part 1: Drop SCRIPT_HOLDER from FetchStreamReader r=smaug

It's not holding any JS objects anymore, probably since the migration to DOM streams.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1865640 - Part 2: Grab StrongWorkerRef in StartConsuming instead of Create r=smaug

Depends on D194089

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1865640 - Part 3: Assert non-native readable stream r=smaug

Depends on D194090

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Try: https://treeherder.mozilla.org/jobs?repo=try&revision=e5b1fef03ff667edf9db1ebda5e990370e5ccbfe

Edit: https://treeherder.mozilla.org/jobs?repo=try&revision=584a5631b2f7f7d0b0dc05b60ed86a8da3261b04 which interestingly still fails...

Comment 5

[Phabricator Automation]

Comment on attachment 9364666 [details]
Bug 1865640 - Part 3: Assert non-native readable stream r=smaug

Revision D194186 was moved to bug 1866078. Setting attachment 9364666 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72186a121dc0
Part 1: Drop SCRIPT_HOLDER from FetchStreamReader r=smaug
https://hg.mozilla.org/integration/autoland/rev/14e583d8b48a
Part 2: Grab StrongWorkerRef in StartConsuming instead of Create r=smaug

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/72186a121dc0
https://hg.mozilla.org/mozilla-central/rev/14e583d8b48a