1865739 - Mouse cursor inappropriately changes icon

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[tgn-ff]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

On KDE, both X11 and Wayland:

1. Move the mouse to the corner that triggers the Overview (which presents all open windows in current virtual desktop).
2. Select a Firefox window to focus on it. Make sure it's in a position that the pointer will be over Firefox afterwards.

Actual results:

The cursor often, but not always, changes to the resizing icon until you hover over some text or a link. Even when not stuck, it seems it changes to the resizing icon for an instant.

There's a similar issue filed on KDE bug tracker: https://bugs.kde.org/show_bug.cgi?id=474039

Expected results:

This seems to be regressed by Bug 1826778. I don't think I have this issue for more than a month now (the patch on Firefox landed six months ago), so it's possible that there was some change on KDE's side that made it worse.

Comment 1

[tgn-ff]

Mozregression result:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4c70b057a3c1ef090eda09ffc896dbda8d464d07&tochange=9fea6478ee86353187486347c908da969c4ac598

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:stransky, since you are the author of the regressor, bug 1826778, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1865739 [Linux] Lock mouse cursor for PIP windows only r?emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93f0f84e3f9b
[Linux] Lock mouse cursor for PIP windows only r=emilio

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826778

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/93f0f84e3f9b

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9364669 [details]
Bug 1865739 [Linux] Lock mouse cursor for PIP windows only r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Incorrect cursor type on KDE / main Firefox window.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor patch, we restrict cursor management to PIP window only.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9364669 [details]
Bug 1865739 [Linux] Lock mouse cursor for PIP windows only r?emilio

Approved for 121.0b3

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/89a964072011

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! I installed a Kubuntu 23.10 KDE on a VM and tried to reproduce the issue with X11. On the affected builds I can sometimes see a resize cursor for a split second after Entering Overview (Windows key+ W) and choosing a Firefox window. However the issue is very intermittent for me and I could not make the resize icon stay like explained in comment 0, even if I tried multiple times.

I tried to verify the issue with Firefox 122.0a1 (2023-11-29) and 121.0b4 on the same VM, but given that the issue is so intermittent, I can not guarantee that it is fixed. I am dropping the qe+ flag based on the above and the fact that I have no reliable steps to reproduce/ verify this issue.

Given the fact that the issue is more reproducible on your side based on the mozregression pushlog can you please also try to see if the issue is fixed with the latest Firefox beta and the latest Firefox Nightly? Thank you in advance!

Comment 12

[tgn-ff]

I tested it on Nightly and beta, and although I still see the mouse cursor changing to a resize icon for a fraction of a second, it doesn't get stuck any more.

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to tgn-ff from comment #12)

I tested it on Nightly and beta, and although I still see the mouse cursor changing to a resize icon for a fraction of a second, it doesn't get stuck any more.

Thank you very much for the verification.

Should we open a new issue for the remaining problem? I understand that the issue is still reproducible but not as visible as before.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #13)

Should we open a new issue for the remaining problem? I understand that the issue is still reproducible but not as visible as before.

It may be something different and unrelated, the original problem here is for PIP windows. So it's up to you.

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #14)

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #13)

Should we open a new issue for the remaining problem? I understand that the issue is still reproducible but not as visible as before.

It may be something different and unrelated, the original problem here is for PIP windows. So it's up to you.

Thank you! I think that filling one for tracking purposes would be fine.

Reporter, do you want to file the issue? If you don't have the time I can do that. Thank you in advance!

Comment 16

[tgn-ff]

That has a different regressor. I've filed Bug 1868752.