Closed
Bug 1865750
Opened 1 year ago
Closed 1 year ago
Remove "Base" comment heading on both `tokens-brand.css` and `tokens-platform.css` above "Typography" tokens
Categories
(Toolkit :: Themes, task)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
122 Branch
Tracking | Status | |
---|---|---|
firefox122 | --- | fixed |
People
(Reporter: jules, Assigned: jules)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-reusable-components])
Attachments
(1 file)
We apply our font size tokens outside of the "base" context and to many different features and uses, and I've mistakenly assigned some of them to fall under "Base" tokens category - which are the foundational styles that shouldn't be used directly since their names don't carry any meaning - e.g. --color-blue-50
.
tokens-shared.css
is the only file that contains Base tokens today, so let's remove the "Base" comment heading above those Typography tokens in tokens-brand.css
and tokens-platform.css
.
Assignee | ||
Updated•1 year ago
|
Whiteboard: [fidefe-reusable-components]
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Depends on D189004
Updated•1 year ago
|
Assignee: nobody → jules
Attachment #9364634 -
Attachment description: WIP: Bug 1865750 - Remove "Base" comment heading on both `tokens-brand.css` and `tokens-platform.css` above "Typography" tokens → Bug 1865750 - Remove "Base" comment heading on both `tokens-brand.css` and `tokens-platform.css` above "Typography" tokens
Status: NEW → ASSIGNED
Pushed by jsimplicio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3fc0213f527
Remove "Base" comment heading on both `tokens-brand.css` and `tokens-platform.css` above "Typography" tokens r=desktop-theme-reviewers,reusable-components-reviewers,mstriemer,dao
Comment 3•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•