1865781 - ETP exceptions "Turn on for all sites" button doesn't work on first try

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, defect)

Description

[Andrei Jolțan [:Andi]]

Steps to reproduce

1. Navigate to any website.
2. Switch OFF the ETP toggle from the site security info panel.
3. Go to Settings -> Enhanced Tracking Protection -> Exceptions.
4. Tap the "Turn on for all sites" button.

Expected behavior

The website is removed from the exceptions list after pressing the "Turn on for all sites" button

Actual behavior

The website is still displayed from the exceptions list after pressing the "Turn on for all sites" button
It's only removed after pressing the second time the "Turn on for all sites" button

Device information

• Firefox version:
  • RC 120
  • Beta 121.0b1
  • Nightly 122.0a1 11/21

• Android device model:
  • Pixel 3a (Android 11)
  • Pixel 2 (Android 9)

Any additional information?

Discovered the problem while investigating flaky EnhancedTrackingProtectionTest#clearWebsitesFromTPExceptionListTest

Comment 1

[Andrei Popa]

Attachment: Bug 1865781 - Fix for removing websites from exceptions list after button press

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fc6cc88f49c
Fix for removing websites from exceptions list after button press r=android-reviewers,gmalekpour

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8fc6cc88f49c