1865792 - Crash in [@ mozilla.appservices.fxaclient.FxaException$OriginMismatch: at mozilla.appservices.fxaclient.FfiConverterTypeFxaError.read(fxa_client.kt)]

Status: RESOLVED FIXED

(Fenix :: Accounts and Sync, defect)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/5d6ae641-6c2a-4cd3-9d49-24c0f0231120

This appears to be a regression, it started in nightly with buildid 20231117214639.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1865792 - FxA OriginMismatch exceptions (#4552)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

For more information, please visit BugBot documentation.

Comment 3

[Chris Peterson [:cpeterson]]

Ben, does FxaException$NoExistingAuthFlow exception https://crash-stats.mozilla.org/report/index/9926eab7-85d2-462f-a279-46fcd0231121 have the same root cause as this FxaException$OriginMismatch bug? Or should I file a new bug report for it?

[@ mozilla.appservices.fxaclient.FxaException$NoExistingAuthFlow: at mozilla.appservices.fxaclient.FfiConverterTypeFxaError.read(fxa_client.kt) ]

Comment 4

[Ben Dean-Kawamura [:bdk]]

Yes and no.

The OriginMismatch crash happened because I added a new FxA error type. NoExistingAuthFlow has been around for a while, I don't think any recent change should have caused it.

That said, I think the fix is the same, we should remove that error type from the shouldPropagate list. Mike: does that make sense to you? If so, I can update the existing PR. If not, let's create a new bug and fix them in separate PRs.

Comment 5

[BMO Github Automation]

Authored by https://github.com/bendk
https://github.com/mozilla-mobile/firefox-android/commit/f09c1dcdd89f92102096e32941c60120bfe05a70
[main] Bug 1865792 - FxA OriginMismatch exceptions

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1865792 - FxA OriginMismatch exceptions (backport #4552) (#4582)

Comment 7

[Mike a [:mavduevskiy]]

Comment on attachment 9365268 [details] [review]
[mozilla-mobile/firefox-android] Bug 1865792 - FxA OriginMismatch exceptions (backport #4552) (#4582)

Beta/Release Uplift Approval Request

• User impact if declined: OriginMismatch exceptions from A-S layer with crash the app (they are not panic and they shouldn't)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): the patch puts a recently added to A-S type of exception into not-to-be-propagated bucket of exceptions from A-S
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Lorand Janos]

Since there are no steps to follow to reproduce this issue, I'll just remove the qe-verify+ flag.

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9365268 [details] [review]
[mozilla-mobile/firefox-android] Bug 1865792 - FxA OriginMismatch exceptions (backport #4552) (#4582)

Approved for Android 121.0b3

Comment 10

[BMO Github Automation]

Authored by https://github.com/bendk
https://github.com/mozilla-mobile/firefox-android/commit/23f6f5d52d64f40c224a33dc11104c6da4d5d473
[releases_v121] Bug 1865792 - FxA OriginMismatch exceptions

Comment 11

[Ben Dean-Kawamura [:bdk]]

Thanks for fixing this one. I made https://bugzilla.mozilla.org/show_bug.cgi?id=1866799 for NoExistingAuthFlow