1865797 - Wait for the promise of fullscreen request to be resolved in test /test_lock_orientation_with_pending_fullscreen.html

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Edgar Chen [:edgar]]

I looked at recent failure log of bug 1838112,

• https://treeherder.mozilla.org/logviewer?job_id=436849293&repo=autoland&lineNumber=3583
• https://treeherder.mozilla.org/logviewer?job_id=436834680&repo=mozilla-central&lineNumber=3704
• https://treeherder.mozilla.org/logviewer?job_id=436812624&repo=autoland&lineNumber=3705

All failure reasons are

WARNING - TEST-UNEXPECTED-FAIL | /tests/dom/base/test/test_lock_orientation_with_pending_fullscreen.html logged result after SimpleTest.finish(): Fullscreen request is canceled.

It seem the check for the fullscreen cancellation runs after test has finished.
It looks like a test error to me. Perhaps the test should also wait for the promise of fullscreen request to be resolved.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1865797 - Wait for the promise of fullscreen request to be resolved; r?m_kato

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d26431f39208
Wait for the promise of fullscreen request to be resolved; r=m_kato

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d26431f39208