1865827 - The webcompat modal's Report Broken Site title has a hover effect like a button

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Daniel Bodea [:danibodea]]

Attachment: Report Broken Site title has hover effect.png

Found in

• Beta v121.0b1

Affected versions

• Nightly v121.0a1
• Beta v121.0b1

Tested platforms

• Affected platforms: Windows 10, MacOS 11, Ubuntu 22
• Unaffected platforms: -

Steps to reproduce

1. Make sure new webcopmpat feature is enabled:
   ui.new-webcompat-reporter.enabled = true
2. Load any webpage
3. Go to Hamburger Menu / Report broken site
4. Hover over the modal's "Broken Site Report" title

Expected result

• The title does not have a hover effect.

Actual result

• The title does not have a hover effect.

Regression range

• not a regression, but an implementation flaw.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:danibodea, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1865827 - add tests to ensure the back button appears and functions appropriately for Report Broken Site popups; r?gijs

Comment 3

[Itiel]

Attachment: Bug 1865827 - Make the Report Broken Site panel more similar to other panels, and simplify some CSS r?#theme,gijs,twisniewski

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba52ce592626
add tests to ensure the back button appears and functions appropriately for Report Broken Site popups; r=Gijs,desktop-theme-reviewers,emilio

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ba52ce592626

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c55ba39f2f4c
Make the Report Broken Site panel more similar to other panels, and simplify some CSS r=Gijs,twisniewski,desktop-theme-reviewers,emilio

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c55ba39f2f4c

Comment 8

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9365046 [details]
Bug 1865827 - Make the Report Broken Site panel more similar to other panels, and simplify some CSS r?#theme,gijs,twisniewski

Beta/Release Uplift Approval Request

• User impact if declined: Some of the UI elements on the new Report Broken Site feature will be buggy, with extra hover effects and bugs with its resizable text-area. Uplifting this will also help uplift bug 1865815. (Uplifting the other patch here is optional, as it only contains tests).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only affects the Report Broken Site feature, which is preffed off by default, and will only see a limited experiment in the 121 cycle.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365021 [details]
Bug 1865827 - add tests to ensure the back button appears and functions appropriately for Report Broken Site popups; r?gijs

Approved for 121.0b7.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/25daa3edeb69
https://hg.mozilla.org/releases/mozilla-beta/rev/c6d71b2ac7d2

Comment 11

[Daniel Bodea [:danibodea]]

This issue has been verified in Nightly v122.0a1. Beta v121.0b7 is yet to be released to verify the Beta channel.
Testing was done on Windows 10, MacOS 11 and Ubuntu 22.

Comment 12

[Daniel Bodea [:danibodea]]

This issue has also been verified in Beta v121.0b7 on Windows 10, MacOS 11 and Ubuntu 22.