1865867 - ApartmentRegion improvements

Status: RESOLVED FIXED

(Core :: IPC: MSCOM, task)

Description

[Ray Kraesig [:rkraesig]]

New uses of ApartmentRegion and its derivatives should probably exclude OLE1 by default; and also should be linted against, just like CoInitializeEx.

Comment 1

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1865867 - [1/2] Modernize ApartmentRegion{,T} r?handyman!

Modernize and clean up ApartmentRegion.h:

• Apply all of clang-tidy's suggestions.

• Rename the template parameter T (which, as a template parameter, is
  typically reserved for types) to AptType.

• When using ApartmentRegionT, include COINIT_DISABLE_OLE1DDE by
  default. (Out of an abundance of caution, do not do so for
  ApartmentRegion.)

Comment 2

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1865867 - [2/2] Add lint for ApartmentRegion and derivatives r?handyman!

Add a lint (paralleling the existing lint for CoInitializeEx) for new
uses of the utility classes defined in ApartmentRegion.h.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d362774cc826
[1/2] Modernize ApartmentRegion{,T}  r=handyman
https://hg.mozilla.org/integration/autoland/rev/bc641d1de7e2
[2/2] Add lint for ApartmentRegion and derivatives  r=handyman

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d362774cc826
https://hg.mozilla.org/mozilla-central/rev/bc641d1de7e2