Closed Bug 1865885 Opened 2 years ago Closed 2 years ago

Able to use date picker in input[type=date] disabled by containing fieldset

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Version:
Firefox 121
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- wontfix
firefox120 --- wontfix
firefox121 --- wontfix
firefox122 --- wontfix
firefox123 --- fixed

People

(Reporter: e61k78gh8, Assigned: ayeddi)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

reporter's testcase.html
251 bytes, text/html
Details
Bug 1865885 - Ensure the date picker in input[type=date] is disabled by containing fieldset. r=emilio!
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

In the minimal example below, click the date picker button.

<!DOCTYPE html>
<html>
<body>

Disabled date input (expected behaviour):<br/>
<input type="date" disabled/>

<fieldset disabled>
<legend>Date input disabled by containing fieldset</legend>
<input type="date"/>
</fieldset>

</body>
</html>

This happens in Firefox nightly

Name: Firefox
Version: 122.0a1
Build ID: 20231121045833
Distribution ID:
Update Channel: nightly
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:122.0) Gecko/20100101 Firefox/122.0
OS: Windows_NT 10.0 19044

Actual results:

I can open the date picker and set the date.

Expected results:

I shouldn’t be able to set the date, as in the disabled input shown in the minimal example.

Status: UNCONFIRMED → NEW
Ever confirmed: true

Thank you for reporting the issue, Iuri Rezende Souza! And thank you both Emilio and Alice for the investigation!

I'll work on the fix ASAP.

Assignee: nobody → ayeddi
Assignee: ayeddi → emilio

I didn't take this intentionally, I won't have time to finish comment 5 today for sure, and it's totally untested, so if you have the cycles to poke and investigate feel free to. Otherwise I'll try to get back to it this or next week :)

Assignee: emilio → nobody
Severity: -- → S3
Attachment #9364804 - Attachment description: WIP: Bug 1865885 - Untested WIP → WIP: Bug 1865885 - Ensure the date picker in input[type=date] is disabled by containing fieldset
Assignee: nobody → ayeddi
Status: NEW → ASSIGNED

Depends on D194271

Attachment #9364804 - Attachment description: WIP: Bug 1865885 - Ensure the date picker in input[type=date] is disabled by containing fieldset → Bug 1865885 - Ensure the date picker in input[type=date] is disabled by containing fieldset. r=emilio!
Attachment #9366670 - Attachment is obsolete: true
Depends on: 1868579
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e5bb9cc6a82a Ensure the date picker in input[type=date] is disabled by containing fieldset. r=emilio,desktop-theme-reviewers,reusable-components-reviewers,hjones

https://hg.mozilla.org/mozilla-central/rev/e5bb9cc6a82a

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox123: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
No longer depends on: 1868579
See Also: → 1868579
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: