1865917 - Some tests are failing intermittently in pdf.js repo

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Calixte Denizet (:calixte)]

STR:

• setup a local dev env for pdf.js: https://github.com/mozilla/pdf.js/#getting-the-code
• run gulp unittest

Few tests (almost always the same) are more or less failing from a run to an other.
In using mozregression, I managed to get this push log:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=211dc86c8f534a950af69434fa996976b566a6a0&tochange=ff2400205932f8f2ee88d4b4f2680628e060434f

My feeling is that the worker cannot be gc-ed during a test.
For example this test is frequently failing:
https://github.com/mozilla/pdf.js/blob/83f00292129674c3b1c92c8629a8b50d3c5a6edd/test/unit/api_spec.js#L3806-L3874
The task is created at the beginning of the test and destroyed at the end.
The worker is created here:
https://github.com/mozilla/pdf.js/blob/83f00292129674c3b1c92c8629a8b50d3c5a6edd/src/display/api.js#L2122C27-L2122C27
then added in the PDFWorker object:
https://github.com/mozilla/pdf.js/blob/83f00292129674c3b1c92c8629a8b50d3c5a6edd/src/display/api.js#L2154-L2155
and the PDFWorker is added to the task:
https://github.com/mozilla/pdf.js/blob/83f00292129674c3b1c92c8629a8b50d3c5a6edd/src/display/api.js#L360C6-L360C6

:edenchuang, could you have a look please ?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1836700

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

The fix on bug 1865774 should fix the over-zealous GC problem; sorry about that!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:edenchuang, since you are the author of the regressor, bug 1836700, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Donal Meehan [:dmeehan]]

:calixte bug 1865774 landed in central and was uplifted to beta.
Could you, or :echuang, confirm comment 0 has been addressed?

Comment 5

[Calixte Denizet (:calixte)]

I tested and it now works for me.

Comment 6

[Donal Meehan [:dmeehan]]

Thanks for checking