1865923 - [wpt-sync] Sync PR 42947 - [CompositeClipPathAnimations] Fix crash for animation fill forward

Status: RESOLVED FIXED

(Core :: Web Painting, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 42947 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42947
Details from upstream follow.

Claire Chambers <[e-mail]> wrote:

[CompositeClipPathAnimations] Fix crash for animation fill forward

This CL fixes a crash that occurred when animation-fill-mode is set to forwards. This crash occurs because invalidating the paint property data on the animated element is contingent upon the clip path data actually changing, which might not happen if the system has had a frame on main thread recently enough that the clip path hasn't changed - or if the animation is using a slow or steps() timing function. Without updating this data, the layout object with the animation will still have a mask based clip, but without an active animation. Because mask based clip isn't designed for shape clip paths, a crash results.

This change makes a change from having a composited clip animation to not having one unconditionally invalidate paint properties for a given LayoutObject, ensuring mask based clip stops being used when it is no longer applicable.
 

Bug: 1497795
Change-Id: I1b2958c84607f2fa8bbe37fe7e860ef47a364fe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003331
Commit-Queue: Claire Chambers \<[e-mail]>
Reviewed-by: Xianzhu Wang \<[e-mail]>
Reviewed-by: Olga Gerchikov \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1227521}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a337fbd12b34b2ba1761a4368f39653754af09

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7eeced2bfc2
[wpt PR 42947] - [CompositeClipPathAnimations] Fix crash for animation fill forward, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6741a344003c
[wpt PR 42947] - [CompositeClipPathAnimations] Fix crash for animation fill forward, a=testonly

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6741a344003c