1865929 - TodoMVC-Backbone spends a lot of time lazy parsing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Denis Palmeiro [:denispal]]

Spinning the backbone part of bug 1833464 off into a separate bug. From https://bugzilla.mozilla.org/show_bug.cgi?id=1833464#c6, it seems there are a few scripts we do not full parse ahead of time due to size heuristics.

Comment 1

[Denis Palmeiro [:denispal]]

There are some minor sp3 improvements if we full parse tiny scripts https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=b003321c9ea7d2bc2645c6e54614bc7e479d7760&newProject=try&newRevision=a1a48addb24976edf427b021b91c7740b331f92b&page=1&framework=13

Comment 2

[Denis Palmeiro [:denispal]]

Attachment: Bug 1865929: Apply delazify strategy to small scripts in ScriptLoader. r=nbp!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b8e34ded03e
Apply delazify strategy to small scripts in ScriptLoader. r=nbp

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3b8e34ded03e

Comment 5

[Mayank Bansal]

This improved AWFY-Sunspider by 3.6%

Comment 7

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #3)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b8e34ded03e
Apply delazify strategy to small scripts in ScriptLoader. r=nbp

== Change summary for alert #40425 (as of Tue, 28 Nov 2023 08:07:59 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
4%	sunspider	linux1804-64-shippable-qr	fission webrender	192.30 -> 184.85	Before/After
3%	sunspider	linux1804-64-shippable-qr	fission webrender	191.90 -> 186.01	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40425

Comment 8

[Andrej (:aglavic)]

(In reply to Cosmin Sabou [:CosminS] from comment #4)

https://hg.mozilla.org/mozilla-central/rev/3b8e34ded03e

== Change summary for alert #40433 (as of Tue, 28 Nov 2023 19:37:03 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	perf_reftest_singletons display-none-1.html	windows10-64-shippable-qr	e10s fission stylo webrender	0.55 -> 0.50
10%	perf_reftest_singletons slow-selector-1.html	macosx1015-64-shippable-qr	e10s fission stylo webrender	0.65 -> 0.59
9%	perf_reftest_singletons display-none-1.html	macosx1015-64-shippable-qr	e10s fission stylo webrender	0.59 -> 0.54
9%	perf_reftest_singletons slow-selector-2.html	macosx1015-64-shippable-qr	e10s fission stylo webrender	0.65 -> 0.60
9%	perf_reftest_singletons slow-selector-2.html	windows10-64-shippable-qr	e10s fission stylo webrender	0.56 -> 0.51
...	...	...	...	...
5%	perf_reftest_singletons nth-index-1.html	windows10-64-shippable-qr	e10s fission stylo webrender	1.16 -> 1.10

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40433