1865931 - Add support for starting the profiler using UNIX signals.

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Some UI crashes/hangs are difficult to diagnose with external (tracing) profilers, as they do not capture gecko markers, and other firefox-specific information. In these cases, starting the Gecko profiler is not possible either, as it need a UI.

This bug captures the process of correctly starting the Gecko profiler using a UNIX signal, but does not cover the process of stopping or gathering profiles (see bugs 1823370, 1865930, and 1865932)

Comment 1

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Attachment: Bug 1865931: Add support for starting the profiler with posix signals r?canaltinova

Comment 2

[J taghdir]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:aabh, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

Hi J taghdir - there's another patch that's blocking the r+'d patch, so it's unlikely to land until that one has.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54db66299bf4
Add support for starting the profiler with posix signals r=canaltinova,profiler-reviewers

Comment 5

[Iulian Moraru]

Backed out for causing xpcshell failures on test_feature_posix_signals.js.

• Push with failures

• Failure log

• Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/669dec1700f0
Add support for starting the profiler with posix signals r=canaltinova,profiler-reviewers,mstange

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/669dec1700f0