1865953 - FreeBSD arm64 missing closing ) at mozglue/baseprofiler/core/platform-linux-android.cpp#l125

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[jsm]

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

Building firefox on FreeBSD arm64

Actual results:

compile time error
mozglue/baseprofiler/core/platform-linux-android.cpp#l125 (missing closing ")" )

Expected results:

compile success

Comment 1

[jsm]

firefox 120.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::mozglue' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:glandium, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:yury, since you are the author of the regressor, bug 1846534, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Yury Delendik (:yury)]

Attachment: Bug 1865953: Fix FreeBSD arm64 missing closing parentheses. r?jpages

Comment 6

[Yury Delendik (:yury)]

I can create a patch. Is there a way to verify it on try?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1846534

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d314be784675
Fix FreeBSD arm64 missing closing parentheses. r=jpages,profiler-reviewers,florian DONTBUILD

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d314be784675

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:yury, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Yury Delendik (:yury)]

Comment on attachment 9367471 [details]
Bug 1865953: Fix FreeBSD arm64 missing closing parentheses. r?jpages

Beta/Release Uplift Approval Request

• User impact if declined: Cannot build FF 121 on FreeBSD
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No affects anything we build.
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9367471 [details]
Bug 1865953: Fix FreeBSD arm64 missing closing parentheses. r?jpages

Approved for 121.0rc1.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3dc2527b0f41