1865969 - [Linux] VA-API support should not be architecture-dependent

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Jiangjin Wang]

User Agent: Mozilla/5.0 (X11; AOSC OS; Linux loongarch64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

Build Firefox for architectures other than x86 and ARM.

Actual results:

vaapitest does not build and VA-API support is absent.

Expected results:

vaapitest should be present and VA-API support should be enabled.

Firefox currently disables VA-API support on any architecture other than x86 and ARM (toolkit/moz.configure line 543). However, libva itself is not architecture-dependent, the assumption that VA-API only works on these architecture is incorrect.

Furthermore, libva is loaded and tested at runtime anyway, enabling VA-API support on all Linux machines brings no harm at all. When VA-API works, it would greatly improve the experience on these platforms.

I've built Firefox 119.0.1 with VA-API support enabled on ppc64el(POWER 9), mips64el(Loongson 3B-4000) and LoongArch64(Loongson 3C-5000), and confirmed it works with dGPU installed.

Comment 1

[Jiangjin Wang]

Attachment: Bug 1865969 - Remove architecture allowlist on VA-API support. r=#media-playback-reviewers,glandium,stransky

Since libva is platform-agnostic and loaded at runtime, there's no harm enabling
it on all platforms running Linux.

This patch has been tested locally on amd64, arm64, ppc64el, mips64el and
loongarch64.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f6fad561a65
Remove architecture allowlist on VA-API support. r=stransky,media-playback-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5f6fad561a65