1865971 - [wpt-sync] Sync PR 43268 - Reland: Put back the dialog SupportsFocus change

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43268 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43268
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Reland: Put back the dialog SupportsFocus change

The [1] CL attempted to change SupportsFocus for dialogs to always
be true, but that caused some dialogs to become keyboard focusable
when they shouldn't be.

This CL re-lands that behavior, but with the keyboard focusability
fixed: IsKeyboardFocusable needed to look explicitly at the things
that allow keyboard focusable dialogs, such as tabindex. Those are
handled by the base class Element::SupportsFocus.

This also adds a DCHECK in focus_controller to make sure things
that are IsKeyboardFocusable() do not have negative tabindexes.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4959753
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-focusability.html

Bug: 1499838
Change-Id: I7e87d1f707c35545e48e53bba58b5ba4cbce5124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5034524
Auto-Submit: Mason Freed \<[e-mail]>
Reviewed-by: Di Zhang \<[e-mail]>
Commit-Queue: Mason Freed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1227721}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 43268 applied with additional changes from upstream: 46a99559f2d55c96927f97969afd32202304a209

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=185f403459e1df47300b686d75daea8a413a96be

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/068b13d20196
[wpt PR 43268] - Reland: Put back the dialog SupportsFocus change, a=testonly

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4bcfc4a9585
[wpt PR 43268] - Reland: Put back the dialog SupportsFocus change, a=testonly

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a4bcfc4a9585