1865984 - Add FenceD3D11 handling to WebGL on Windows

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

It seems better to use ID3D11Fence with WebGL if it is supported. Since WebGPU needs to use ID3D11Fence.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1865984 - Add FenceD3D11 handling to WebGL on Windows

Comment 2

[Jeff Muizelaar [:jrmuizel]]

What advantage does using ID3D11Fence provide?

Comment 3

[Sotaro Ikeda [:sotaro]]

If we want to implement GPUQueue:copyExternalImageToTexture(), HTMLCanvasElement and OffscreenCanvas could also be used as source.

• https://developer.mozilla.org/en-US/docs/Web/API/GPUQueue/copyExternalImageToTexture

In this case, ID3D11Texture2D of SharedSurface_ANGLEShareHandle is going to be imported to WebGPU(wgpu).
If we want to interact with WebGPU with D3D12 backend, SharedSurface_ANGLEShareHandle needs to provide ID3D11Fence for performance.

From it, all canvas that use ID3D11Texture2D will need to implement ID3D11Fence for performance.
And if WebGL support ID3D11Fence, we could check if ID3D11Fence implementation works as expected soon.

chromium implementation does like the following. The BeginAccessDawn() send wait fences to dawn(WebGPU)

GPUQueue::CopyFromCanvasSourceImage()
->WebGPUMailboxTexture::FromStaticBitmapImage()
->WebGPUMailboxTexture::FromCanvasResource()
->WebGPUMailboxTexture::WebGPUMailboxTexture()
->/// ipc
->WebGPUImplementation::AssociateMailbox()
->WebGPUDecoderImpl::HandleAssociateMailboxImmediate()
->WebGPUDecoderImpl::AssociateMailboxDawn()
->DawnImageRepresentation::BeginScopedAccess()
->DawnImageRepresentation::BeginAccess()
->DawnD3DImageRepresentation::BeginAccess()
->D3DImageBacking::BeginAccessDawn()

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c9c6fcfe2f6
Add FenceD3D11 handling to WebGL on Windows r=gfx-reviewers,lsalzman,aosmond

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4c9c6fcfe2f6

Comment 7

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c9c6fcfe2f6
Add FenceD3D11 handling to WebGL on Windows r=gfx-reviewers,lsalzman,aosmond

Perfherder has detected a talos performance change from push 4c9c6fcfe2f60516f9db5f65fa0ec558b2dc88cc.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
42%	glterrain	windows11-64-shippable-qr	e10s fission stylo webrender-sw	2.79 -> 1.62

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 44724

The following documentation link provides more information about this command.