1866130 - --push-to-lando failed after importing a patch stack from phabricator

Status: NEW

(Conduit :: Lando, defect)

Description

[[e-mail] (:bhearsum)]

I imported a stack to a cinnabar repo with: moz-phab patch D193799

Then I added a commit on top of it, and tried to push it to try with ./mach try again --push-to-lando. I ended up with this failure e-mail:

Your request to land try push with tip commit 'debug' failed.

Reason:
Unexpected error while fetching repo from https://hg.mozilla.org/mozilla-unified.
hg error in cmd: hg update --clean -r faa879dcf13a3a72b5bb85d715563871a3ad56bc:
abort: unknown revision 'faa879dcf13a3a72b5bb85d715563871a3ad56bc'

It pushed fine when I used plain ./mach try again.

Comment 1

[[e-mail] (:bhearsum)]

https://phabricator.services.mozilla.com/D193865#6434019 is possibly another instance of this (although I don't know if it was with an imported stack or not).

Comment 2

[Kash Shampur [:kshampur] ⌚EST]

I can confirm in that case ^ that it was not from a imported stack

Comment 3

[Connor Sheehan [:sheehan]]

Ben, did you push your changes to your mac remote again, such that there may be a remote branch that isn't related to gecko-dev in your local repo? I imagine that's the case, and git cinnabar hg2git faa879dcf13a3a72b5bb85d715563871a3ad56bc will point to a local development commit.

Once we implement the changes recommended in bug 1856590 comment 10 this should be resolved, but just want to double check that's the case here.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Connor Sheehan [:sheehan] from comment #3)

Ben, did you push your changes to your mac remote again, such that there may be a remote branch that isn't related to gecko-dev in your local repo? I imagine that's the case, and git cinnabar hg2git faa879dcf13a3a72b5bb85d715563871a3ad56bc will point to a local development commit.

I did push there again, yeah.

❯ git cinnabar hg2git faa879dcf13a3a72b5bb85d715563871a3ad56bc
a364f93e68071cdf2f7334099271dce64c619e18

Comment 5

[Liz Henry (:lizzard)]

Moving this out from the hg-to-git meta bug, as the team is not considering it a blocker for production deployment.

Comment 6

[Liz Henry (:lizzard)]

My mistake, we will keep this under bug 1835958, but move that entire meta bug out from under hg-to-git!