1866266 - Enable LargestContentfulPaint in Release

Status: RESOLVED FIXED

(Core :: Performance, task)

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1866266 - Enable LargestContentfulPaint in Release r=emilio

Comment 2

[Sean Feng [:sefeng]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This is one of the most wanted Web Performance API
[Affects Firefox for Android]: Yes
[Suggested wording]: The LargestContentfulPaint API has now been added, to provide timing information about the largest or text paint before users interact a web page.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/LargestContentfulPaint

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dc051006d87
Enable LargestContentfulPaint in Release r=emilio

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5dc051006d87

Comment 5

[Donal Meehan [:dmeehan]]

Added a slightly reworded note to the Fx122 nightly release notes, please allow 30 mins for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx122 release notes

Comment 6

[Sean Feng [:sefeng]]

Comment on attachment 9365198 [details]
Bug 1866266 - Enable LargestContentfulPaint in Release r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: One of the most wanted web performance API will be shipped one version late
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1867266
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature itself has been running on Nightly for a while so it's working as expected. This change is about turning that on in Release which is low risky.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I'm not super crazy about enabling this so late in the cycle when it's been off for the first half of the Beta cycle (i.e. NIGHTLY_BUILD vs. EARLY_BETA_OR_EARLIER). How concerned are we about that?

Comment 8

[Sean Feng [:sefeng]]

oh I didn't aware this is too late now as I thought we still have like 2 weeks. But yeah, if it's being considered as late in the cycle, please approval-mozilla-beta- . I'd also love to make sure it's stable for a long enough time.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365198 [details]
Bug 1866266 - Enable LargestContentfulPaint in Release r=emilio

If this had ridden 121 to Beta behind an EARLY_BETA_OR_EARLIER flag (or even if that had been landed earlier in the cycle), I think it would have been reasonable to request this now when you did. But having been completely disabled on Beta for the last 2 weeks leaves me feeling less confident about that. If there isn't a strong business need for this to ship this cycle, I'd vote for letting it ride 122 instead. Don't hesitate to reach out if we need to discuss further!

Comment 10

[Brian Thomas Smith [bsmth]]

MDN updates for this can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/31110