1866272 - Fix the support for WPT print reftests on macOS

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P2)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1866272. Support CSS page-size in WPT print reftests on macOS. r=emilio

In 1760836, we added support for printing PDF to nsIOutputStream because
GeckoView needs that to save webpages as PDFs. At some point since then, WPT
print reftests started to use this code path. Unfortunately, the
print-pdf-to-stream code on macOS has been creating PDF output with very small
pages, and ignoring any attempts to set page size from CSS or nsIPrintSettings.

I assume this issue went unnoticed when the WPT print reftests started to use
the print-pdf-to-stream code because tests and references were both equally
affected. However, the tests that I'm creating for mixed page sizes fail if
they can't set the page size properly. This patch fixes that issue so that I
can land those tests.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6354cfb105a6
Support CSS page-size in WPT print reftests on macOS. r=emilio

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6354cfb105a6

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 9365219 [details]
Bug 1866272. Support CSS page-size in WPT print reftests on macOS. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: Blocks 1836059, which is currently enabled for early beta, but we want to ride the trains in v121 as part of an H2 goal.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Tests only. (All automated tests passed on Nightly shortly after the 121 branch, so very likely the same on 121.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365219 [details]
Bug 1866272. Support CSS page-size in WPT print reftests on macOS. r=emilio

Approved for 121.0b5.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/22785f6abc94