1866316 - RTL - shopping sidebar container flickers on the right side when opening/closing the sidebar

Status: NEW

(Firefox :: Shopping, defect, P3)

Description

[kpatenio]

Attachment: sidebar_flicker_close.mov

STR:

1. Enable bidi mode in Browser Toolbox (alternatively: load Firefox in RTL language)
2. Make sure sidebar feature is enabled and profile is opted in
3. View product page (example) and ensure shopping sidebar is visible
4. Close sidebar with urlbar shopping icon or the close button on the sidebar

Expected:

• there should be no sudden flicker on the right side of the page when closing/opening the sidebar in RTL mode

Actual:

• there is a slight flicker on the right side of the page, which is very distracting visually

Notes:

• this issue probably existed for a while, but I believe that it will be way more obvious once we show sidebar animations.
• I tested this on MacOS and can't recall at the moment if it also occurs on other platforms

Comment 1

[kpatenio]

Considering how visible this issue is, I'm going to nominate it for 122. Please change as needed.

Comment 2

[kpatenio]

Attachment: sidebar_delay_with_animation_RTL.mov

Follow-up on how it looks in RTL mode after landing the sidebar animation on close / open (local Nightly build).

Comment 3

[kpatenio]

Attachment: new_nightly_122_AR_build_animation_flicker.mov

Testing with today's Nightly (non-local build this time), the flicker is no longer delayed like in comment 2. Not sure why it was like that in the second recording, but I can confirm at least with today's Nightly that it's more like in the first recording.

Third recording is with an actual AR Nightly build.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

There's no current plan to ship in RTL languages, so I'm going to move this into the generic shopping backlog for now. Great catch, though 👍