Closed
Bug 1866319
Opened 2 years ago
Closed 2 years ago
Make WPT use the CSS page size for Print Reftests
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox121 fixed, firefox122 fixed)
RESOLVED
FIXED
122 Branch
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
| Assignee | ||
Comment 1•2 years ago
|
||
Needed in order for upcoming mixed page size tests to work.
| Assignee | ||
Comment 2•2 years ago
|
||
James created a bare-bones WPT RFC to cover this:
https://github.com/web-platform-tests/rfcs/pull/173/commits/f955bed18a6190b7e0d8fdda5e38c2e81706b13b
Thanks, James!
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/65245ae5c5ae
Make WPT use the CSS page size for Print Reftests. r=jgraham,webdriver-reviewers
Comment 4•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
| Assignee | ||
Comment 5•2 years ago
|
||
Comment on attachment 9365266 [details]
Bug 1866319. Make WPT use the CSS page size for Print Reftests. r=jgraham
Beta/Release Uplift Approval Request
- User impact if declined: Blocks 1836059, which is currently enabled for early beta, but we want to ride the trains in v121 as part of an H2 goal.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Tests only. (All automated tests passed on Nightly shortly after the 121 branch, so very likely the same on 121.
- String changes made/needed:
- Is Android affected?: No
Attachment #9365266 -
Flags: approval-mozilla-beta?
Comment 6•2 years ago
|
||
Comment on attachment 9365266 [details]
Bug 1866319. Make WPT use the CSS page size for Print Reftests. r=jgraham
Approved for 121.0b5 since it's basically only impacting tests, but I should note that we're already nearly halfway through the Beta cycle for 121 and it's getting a bit tight for pref flips.
Attachment #9365266 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•2 years ago
|
status-firefox121:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•