nsTreeBodyFrame::InvalidateRange triggers WARNING: empty damage rect: update caller to avoid fcn call overhead

NEW
Assigned to

Status

()

Core
Layout: Misc Code
15 years ago
9 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

15 years ago
cvs build from sunday afternoon, w/ various patches to many places *except layout*.

I'm using venkman and somehow my layout of windows results in one of two things:
bad damage rects and jumping frames. in this case, 

WARNING: empty damage rect: update caller to avoid fcn call overhead, file
i:/build/mozilla/layout/html/base/src/nsFrame.cpp, line 2538
nsFrame::Invalidate(nsIPresContext * 0x107ee9a0, const nsRect & {...}, int 0)
line 2538
nsTreeBodyFrame::InvalidateRange(nsTreeBodyFrame * const 0x12b88f44, int 0, int
0) line 965
nsTreeBoxObject::InvalidateRange(nsTreeBoxObject * const 0x11919ef8, int 0, int
1450) line 372 + 20 bytes
XPTC_InvokeByIndex(nsISupports * 0x11919ef8, unsigned int 25, unsigned int 2,
nsXPTCVariant * 0x00127dfc) line 106

-	rangeRect	{...}
|	x	0
|	y	0
|	width	0
\	height	270

	mInnerBox.width	0

0 [native frame]
1 torr_resort(true) ["chrome://venkman/content/tree-utils.js":1052]
    i = 1451
    this = [object Object]
2 xtvr_appchild(child = [object Object])
["chrome://venkman/content/tree-utils.js":645]
    tree = null
    this = [object Object]
3 scv_hookScriptInstanceSealed(e = [object Object])
["chrome://venkman/content/venkman-views.js":884]
    scr = [object Object]
    this = [object Object]
4 callHooks(command = [object Object], isBefore = false)
["chrome://venkman/content/venkman-static.js":247]
    names = :hook-script-instance-sealed,scripts:hook-script-instance-sealed
    hooks = [object Object]
    len = 2
    i = 1
    name = "scripts:hook-script-instance-sealed"
    this = [object ChromeWindow @ 0x107fe418]
5 dispatchCommand(command = [object Object], flags = undefined, e = [object
Object]) ["chrome://venkman/content/venkman-static.js":338]
    callHooks = [function]
    h = undefined
    i = undefined
    str = undefined
    name = undefined
    commandList = undefined
    newEvent = undefined
    this = [object ChromeWindow @ 0x107fe418]
6 dispatch(text = "hook-script-instance-sealed", e = [object Object], flags =
undefined) ["chrome://venkman/content/venkman-static.js":193]
    ary = [object Object]
    rv = null
    i = undefined
    ex = undefined
    str = undefined
    this = [object ChromeWindow @ 0x107fe418]
7 si_seal() ["chrome://venkman/content/venkman-debugger.js":549]
    nada = undefined
    f = undefined
    this = [object Object]
8 smgr_created(jsdScript = [xpconnect wrapped jsdIScript @ 0x14f81c48])
["chrome://venkman/content/venkman-debugger.js":362]
    instance = [object Object]
    scriptWrapper = undefined
    this = [object Object]
9 jsdScriptCreated(jsdScript = [xpconnect wrapped jsdIScript @ 0x14f81c48])
["chrome://venkman/content/venkman-debugger.js":180]
    url = "chrome://messenger/content/mailWidgets.xml#searchvalue.parentValue
(getter)"
    manager = [object Object]
    this = [object ChromeWindow @ 0x107fe418]
10 sh_created(jsdScript = [xpconnect wrapped jsdIScript @ 0x14f81c48])
["chrome://venkman/content/venkman-debugger.js":144]
    this = [object Object]
11 [native frame]
(Assignee)

Comment 1

15 years ago
Created attachment 110072 [details] [diff] [review]
fix the caller
Comment on attachment 110072 [details] [diff] [review]
fix the caller

Use mInnerBox.IsEmpty() instead.
Attachment #110072 - Flags: superreview-
(Assignee)

Comment 3

15 years ago
Created attachment 110286 [details] [diff] [review]
correct fix for the caller
Attachment #110072 - Attachment is obsolete: true
->misc code (is this ready for review)?
Component: Layout → Layout: Misc Code
Depends on: 233292

Comment 5

11 years ago
(In reply to comment #3)
> Created an attachment (id=110286) [details]
> correct fix for the caller

[never re-reviewed or checked in]

timeless,

starting line has changed to 717 and if statement changed for bug 296040...
 721 Jan.Varga      1.280   if (aStart > aEnd || aEnd < mTopRowIndex || aStart > last)

QA Contact: ian → layout.misc-code
You need to log in before you can comment on or make changes to this bug.