1866420 - [css-grid] Some grid tests does not follow Ahem best practices

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect, P2)

Description

[Tiaan Louw]

Some grid tests are not using the correct font: 15px/1 Ahem setting for fonts and is causing layout errors.

See this page for details:
https://web-platform-tests.org/writing-tests/ahem.html

Comment 1

[Tiaan Louw]

Attachment: Bug 1866420 - Set correct Ahem font properties for grid tests r=#layout

These tests are not following best practice for the Ahem font and are
causing baseline alignment issues as mentioned in the wpt docs:

https://web-platform-tests.org/writing-tests/ahem.html

They now use 15px/1 Ahem. 15px, to stay close to the original size
which is the default of 16px. This shifts the characters on the tests
around, so the expected measurements are also updated.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebacc66038ee
Set correct Ahem font properties for grid tests r=jwatt

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43340 for changes under testing/web-platform/tests

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ebacc66038ee

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot