1866641 - Finish renaming production files to automatically apply the ESLint worker environment

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

We should rename our worker files to use the .worker.(m)js pattern introduced by bug
1846758. This bug is to address all of the remaining production uses.

This avoids manual annotations of the environment. In future, it'll also make migration to the ESLint flat configuration simpler, as that doesn't manage environments in the same way.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1866641 - Allow ESLint worker files to be named simply 'worker.(m)js'. r?Mossop!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1866641 - Rename workers to use the .worker.(m)js pattern for ESLint (devtools/). r?#devtools-reviewers!

Depends on D194697

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1866641 - Rename workers to use the .worker.(m)js pattern for ESLint (remaining production files). r?Mossop!

Depends on D194698

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dfb7cfdc26e
Allow ESLint worker files to be named simply 'worker.(m)js'. r=mossop
https://hg.mozilla.org/integration/autoland/rev/dbe3fabc6e89
Rename workers to use the .worker.(m)js pattern for ESLint (devtools/). r=devtools-reviewers,profiler-reviewers,nchevobbe,canaltinova
https://hg.mozilla.org/integration/autoland/rev/7cab7eb61b23
Rename workers to use the .worker.(m)js pattern for ESLint (remaining production files). r=mossop,translations-reviewers,gregtatum

Comment 5

[Iulian Moraru]

Backed out for causing talos damp failures on browser-toolbox.js.

• Push with failures

• Failure log

• Backout link

[task 2023-11-29T16:16:40.143Z] 16:16:40     INFO -  PID 3060 | Waiting for 0 requests
[task 2023-11-29T16:16:40.745Z] 16:16:40     INFO -  PID 3060 | Close toolbox on 'custom.netmonitor'
[task 2023-11-29T16:16:41.796Z] 16:16:41     INFO -  PID 3060 | Garbage collect
[task 2023-11-29T16:16:42.092Z] 16:16:42     INFO -  PID 3060 | netmonitor/custom.js took 7644ms.
[task 2023-11-29T16:16:42.092Z] 16:16:42     INFO -  PID 3060 | Loading test 'toolbox/panels-in-background.js'
[task 2023-11-29T16:16:42.092Z] 16:16:42     INFO -  PID 3060 | Executing test 'toolbox/panels-in-background.js'
[task 2023-11-29T16:16:42.104Z] 16:16:42     INFO -  PID 3060 | Wait for a pageshow event for browsing context 40
[task 2023-11-29T16:16:42.328Z] 16:16:42     INFO -  PID 3060 | Received pageshow event for 40
[task 2023-11-29T16:16:42.532Z] 16:16:42     INFO -  PID 3060 | Open toolbox on 'webconsole'
[task 2023-11-29T16:16:42.532Z] 16:16:42     INFO -  PID 3060 | Open toolbox - Call showToolboxForTab
[task 2023-11-29T16:16:43.447Z] 16:16:43     INFO -  PID 3060 | Reload page on 'panelsInBackground'
[task 2023-11-29T16:16:43.447Z] 16:16:43     INFO -  PID 3060 | Wait for a pageshow event for browsing context 40
[task 2023-11-29T16:16:43.835Z] 16:16:43     INFO -  PID 3060 | Received pageshow event for 40
[task 2023-11-29T16:16:43.835Z] 16:16:43     INFO -  PID 3060 | Wait for pending paints on 'panelsInBackground.reload'
[task 2023-11-29T16:16:43.836Z] 16:16:43     INFO -  PID 3060 | 'panelsInBackground.reload.settle.DAMP' took 0.04018799999903422ms.
[task 2023-11-29T16:16:45.696Z] 16:16:45     INFO -  PID 3060 | Garbage collect
[task 2023-11-29T16:16:46.188Z] 16:16:46     INFO -  PID 3060 | toolbox/panels-in-background.js took 4097ms.
[task 2023-11-29T16:16:46.189Z] 16:16:46     INFO -  PID 3060 | Loading test 'toolbox/screenshot.js'
[task 2023-11-29T16:16:46.189Z] 16:16:46     INFO -  PID 3060 | Executing test 'toolbox/screenshot.js'
[task 2023-11-29T16:16:46.200Z] 16:16:46     INFO -  PID 3060 | Wait for a pageshow event for browsing context 45
[task 2023-11-29T16:16:46.709Z] 16:16:46     INFO -  PID 3060 | Received pageshow event for 45
[task 2023-11-29T16:16:46.811Z] 16:16:46     INFO -  PID 3060 | Open toolbox on 'webconsole'
[task 2023-11-29T16:16:46.811Z] 16:16:46     INFO -  PID 3060 | Open toolbox - Call showToolboxForTab
[task 2023-11-29T16:16:48.210Z] 16:16:48     INFO -  PID 3060 | [Parent 3060, MediaDecoderStateMachine #1] WARNING: 7f12bc071940 OpenCubeb() failed to init cubeb: file /builds/worker/checkouts/gecko/dom/media/AudioStream.cpp:284
[task 2023-11-29T16:16:48.210Z] 16:16:48     INFO -  PID 3060 | [Parent 3060, MediaDecoderStateMachine #1] WARNING: Decoder=7f12cac1b400 [OnMediaSinkAudioError]: file /builds/worker/checkouts/gecko/dom/media/MediaDecoderStateMachine.cpp:4650
[task 2023-11-29T16:16:48.211Z] 16:16:48     INFO -  PID 3060 | [Parent 3060, MediaDecoderStateMachine #1] WARNING: Decoder=7f12cac1b400 Decode error: NS_ERROR_DOM_MEDIA_MEDIASINK_ERR (0x806e000b) - OnMediaSinkAudioError: file /builds/worker/checkouts/gecko/dom/media/MediaDecoderStateMachineBase.cpp:166
[task 2023-11-29T16:16:48.246Z] 16:16:48     INFO -  PID 3060 | console.warn: "IGNORED REDUX ACTION:" "AUTOCOMPLETE_CLEAR"
[task 2023-11-29T16:16:48.252Z] 16:16:48     INFO -  PID 3060 | Garbage collect
[task 2023-11-29T16:16:48.690Z] 16:16:48     INFO -  PID 3060 | toolbox/screenshot.js took 2502ms.
[task 2023-11-29T16:16:48.691Z] 16:16:48     INFO -  PID 3060 | Loading test 'toolbox/browser-toolbox.js'
[task 2023-11-29T16:16:48.691Z] 16:16:48     INFO -  PID 3060 | Executing test 'toolbox/browser-toolbox.js'
[task 2023-11-29T16:16:48.705Z] 16:16:48     INFO -  PID 3060 | Wait for a pageshow event for browsing context 48
[task 2023-11-29T16:16:48.736Z] 16:16:48     INFO -  PID 3060 | Received pageshow event for 48
[task 2023-11-29T16:16:48.849Z] 16:16:48     INFO -  PID 3060 | DevTools Server for Browser Toolbox listening on port: 40401
[task 2023-11-29T16:16:48.854Z] 16:16:48     INFO -  PID 3060 | Starting Browser Toolbox /home/cltbld/tasks/task_170127231662574/build/application/firefox/firefox-bin -no-remote -foreground -profile /tmp/tmpldqeauso/profile/chrome_debugger_profile -chrome chrome://devtools/content/framework/browser-toolbox/window.html
[task 2023-11-29T16:16:49.410Z] 16:16:49     INFO -  PID 3060 | 6544> console.error: "Warning: unrecognized command line flag" "-foreground"
[task 2023-11-29T16:17:10.072Z] 16:17:10     INFO -  PID 3060 | 6544> Wait for debugger to initialize
[task 2023-11-29T16:17:20.765Z] 16:17:20     INFO -  PID 3060 | 6544> Wait for tab source in the content process
[task 2023-11-29T16:17:23.385Z] 16:17:23     INFO -  PID 3060 | TEST-UNEXPECTED-FAIL | damp | toolbox/browser-toolbox.js: Exception: evaluation failed
[task 2023-11-29T16:17:23.386Z] 16:17:23     INFO -  PID 3060 | evaluateInBrowserToolbox@resource://damp-test/content/tests/toolbox/browser-toolbox.js:188:11
[task 2023-11-29T16:17:23.387Z] 16:17:23     INFO -  PID 3060 | async*module.exports@resource://damp-test/content/tests/toolbox/browser-toolbox.js:86:9
[task 2023-11-29T16:17:23.387Z] 16:17:23     INFO -  PID 3060 |
[task 2023-11-29T16:17:23.391Z] 16:17:23     INFO -  PID 3060 | [DampLoad helper] Unregister DampLoad actors
[task 2023-11-29T16:17:23.395Z] 16:17:23     INFO -  PID 3060 | 6544>
[task 2023-11-29T16:21:48.735Z] 16:21:48     INFO -  PID 3060 | TEST-UNEXPECTED-FAIL | damp | toolbox/browser-toolbox.js: Test timed out
[task 2023-11-29T17:21:48.735Z] 17:21:48     INFO - Automation Error: mozharness timed out after 3600 seconds running ['/home/cltbld/tasks/task_170127231662574/build/venv/bin/python', '/home/cltbld/tasks/task_170127231662574/build/tests/talos/talos/run_tests.py', '--executablePath', '/home/cltbld/tasks/task_170127231662574/build/application/firefox/firefox', '--suite', 'damp-other', '--title', 't-linux64-ms-093', '--symbolsPath', 'https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aoH1hi4MRnqxXydJ70FZxA/artifacts/public/build/target.crashreporter-symbols.zip', '--project', 'autoland', '--screenshot-on-failure', '--setpref=talos.damp.suite=other', '--setpref=gfx.webrender.software=true', '--setpref=media.peerconnection.mtransport_process=false', '--setpref=network.process.enabled=false', '--setpref=layers.d3d11.enable-blacklist=false', '--log-tbpl-level=info', '--log-errorsummary=/home/cltbld/tasks/task_170127231662574/build/blobber_upload_dir/damp-other_errorsummary.log']
[task 2023-11-29T17:21:48.741Z] 17:21:48     INFO - Return code: -9
[task 2023-11-29T17:21:48.741Z] 17:21:48  WARNING - setting return code to -9
[task 2023-11-29T17:21:48.742Z] 17:21:48  WARNING - setting return code to 2
[task 2023-11-29T17:21:48.743Z] 17:21:48     INFO - Running post-action listener: _package_coverage_data
[task 2023-11-29T17:21:48.743Z] 17:21:48     INFO - Running post-action listener: _resource_record_post_action
[task 2023-11-29T17:21:48.743Z] 17:21:48     INFO - Running post-action listener: process_java_coverage_data
[task 2023-11-29T17:21:48.743Z] 17:21:48     INFO - [mozharness: 2023-11-29 17:21:48.743656Z] Finished run-tests step (success)
[task 2023-11-29T17:21:48.744Z] 17:21:48     INFO - Running post-run listener: _resource_record_post_run
[task 2023-11-29T17:21:53.183Z] 17:21:53     INFO - Total resource usage - Wall time: 4000s; CPU: 1%; Read bytes: 120111104; Write bytes: 1212133376; Read time: 336; Write time: 41596
[task 2023-11-29T17:21:53.183Z] 17:21:53     INFO - TinderboxPrint: CPU usage<br/>1.0%
[task 2023-11-29T17:21:53.183Z] 17:21:53     INFO - TinderboxPrint: I/O read bytes / time<br/>120,111,104 / 336
[task 2023-11-29T17:21:53.183Z] 17:21:53     INFO - TinderboxPrint: I/O write bytes / time<br/>1,212,133,376 / 41,596
[task 2023-11-29T17:21:53.183Z] 17:21:53     INFO - TinderboxPrint: CPU idle<br/>31,626.3 (99.0%)
[task 2023-11-29T17:21:53.183Z] 17:21:53     INFO - TinderboxPrint: Swap in / out<br/>0 / 0
[task 2023-11-29T17:21:53.204Z] 17:21:53     INFO - install - Wall time: 10s; CPU: 13%; Read bytes: 24576; Write bytes: 1654784; Read time: 0; Write time: 16
[task 2023-11-29T17:21:54.565Z] 17:21:54     INFO - run-tests - Wall time: 3987s; CPU: 1%; Read bytes: 120086528; Write bytes: 1210478592; Read time: 336; Write time: 41580
[task 2023-11-29T17:22:20.351Z] 17:22:20  WARNING - returning nonzero exit status 2
[taskcluster 2023-11-29T17:22:21.064Z]    Exit Code: 2
[taskcluster 2023-11-29T17:22:21.064Z]    User Time: 5m47.590057s
[taskcluster 2023-11-29T17:22:21.064Z]  Kernel Time: 49.653139s
[taskcluster 2023-11-29T17:22:21.064Z]    Wall Time: 1h10m23.255720497s
[taskcluster 2023-11-29T17:22:21.064Z]       Result: FAILED
[taskcluster 2023-11-29T17:22:21.065Z] === Task Finished ===
[taskcluster 2023-11-29T17:22:21.065Z] Task Duration: 1h10m23.259158306s
[taskcluster 2023-11-29T17:22:21.204Z] Uploading artifact public/logs/localconfig.json from file logs/localconfig.json with content encoding "gzip", mime type "application/json" and expiry 2024-11-28T16:11:53.855Z
[taskcluster 2023-11-29T17:22:21.527Z] Uploading artifact public/test_info/damp-other_errorsummary.log from file build/blobber_upload_dir/damp-other_errorsummary.log with content encoding "gzip", mime type "text/plain" and expiry 2024-11-28T16:11:53.855Z
[taskcluster 2023-11-29T17:22:21.817Z] Uploading artifact public/test_info/profile_resource-usage.json from file build/blobber_upload_dir/profile_resource-usage.json with content encoding "gzip", mime type "application/json" and expiry 2024-11-28T16:11:53.855Z
[taskcluster 2023-11-29T17:22:22.234Z] Uploading artifact public/test_info/resource-usage.json from file build/blobber_upload_dir/resource-usage.json with content encoding "gzip", mime type "application/json" and expiry 2024-11-28T16:11:53.855Z
[taskcluster 2023-11-29T17:22:23.673Z] Uploading link artifact public/logs/live.log to artifact public/logs/live_backing.log with expiry 2024-11-28T16:11:53.855Z
[taskcluster:error] exit status 2

Comment 6

[Mark Banner (:standard8)]

Missed the fact there was a startsWith that was avoiding waiting for slow loading files.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93c77e6b2bac
Allow ESLint worker files to be named simply 'worker.(m)js'. r=mossop
https://hg.mozilla.org/integration/autoland/rev/3193efffa9d3
Rename workers to use the .worker.(m)js pattern for ESLint (devtools/). r=devtools-reviewers,profiler-reviewers,nchevobbe,canaltinova
https://hg.mozilla.org/integration/autoland/rev/f3aeb9958460
Rename workers to use the .worker.(m)js pattern for ESLint (remaining production files). r=mossop,translations-reviewers,gregtatum,devtools-reviewers,nchevobbe

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/93c77e6b2bac
https://hg.mozilla.org/mozilla-central/rev/3193efffa9d3
https://hg.mozilla.org/mozilla-central/rev/f3aeb9958460