1866679 - Json viewer has a blue border around the content

Status: ASSIGNED

(DevTools :: JSON Viewer, enhancement, P3)

Description

[Pascal Chevrel (relman team) -> :pascalc]

Attachment: image.png

When loading a json file, a blue line is now rendered around the page, see screenshot.

If you click on the content, the border disappears

Last good revision: f1f5f98290b348616c33083ee0bef41d8c2cc147
First bad revision: 6a44a533b289fed920d41737bdef46afae72d47d
INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f1f5f98290b348616c33083ee0bef41d8c2cc147&tochange=6a44a533b289fed920d41737bdef46afae72d47d

Nicolas, this seems to have been caused by one of your patches.

Thanks

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This is the focus indicator (for keyboard navigation and accessibility) and its style now matches what we have in the rest of DevTools.
I guess this shows how we automatically put the focus on the "tree" on load, maybe we could revisit that

Comment 2

[BugBot [:suhaib / :marco]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 3

[Donal Meehan [:dmeehan]]

Setting Bug 1865846 as the regressor, please change if incorrect

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1866679 - [devtools] Don't automatically focus JSON viewer content. r=#devtools-reviewers.

Comment 5

[Donal Meehan [:dmeehan]]

:nchevobbe will this land within the next week?
The Fx122 nightly soft code freeze starts on 2023-12-14, with Fx122 going to beta on 2023-12-18.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Not a big deal, for now I'd rather show the proper focus indicator

Comment 7

[Dianna Smith [:diannaS]]

:nchevobbe any updates on this patch?

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

The focus indicator is now fixed, and it seems important that the content gets focused, so I'm not sure we're going to do anything about this.
We'll discuss this with the team

Comment 9

[Julian Descottes [:jdescottes]]

We should make sure to only show one focus indicator at a time.
When you select an element in the tree, we put a blue background on it, and in this case we should no longer show a border on its container, although it currently happens if you do the following:

• select an item
• press up or down to select another item
• -> blue border appears on the container

We should also stop showing the blue background if the item no longer has focus. But the component is fully navigable with the keyboard, so moving to enhancement.