Closed Bug 18667 Opened 26 years ago Closed 24 years ago

[Classic]Mac 'grow box' can overlap and hide security indicator (lock icon)

Categories

(SeaMonkey :: General, defect, P1)

Product:
SeaMonkey
Component:
General
Platform:
PowerPC
Mac System 8.5
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED WORKSFORME
Milestone:
mozilla0.8

People

(Reporter: elig, Assigned: andreww)

References

Details

(Keywords: classic, platform-parity)

Attachments

(2 files)

Screenshot of hidden lock icon
1.12 KB, image/png
Details
proposed patch for bug
257 bytes, patch
Details | Diff | Splinter Review
* TITLE/SUMMARY [PP] Last two digits of Build ID obscured by minimized Taskbar * STEPS TO REPRODUCE 0) Launch Apprunner on a Mac OS system. 1) From the View menu, select "Taskbar" from the Toolbars submenu. * RESULT - What happened The status line inhabits the vertical space previously occupied by the toolbar. The last two digits of the build ID are covered up by the grow box. - What was expected Build date to remain visible, whether taskbar is minimized or not. * REGRESSION - Occurs On Mac OS Apprunner (1999111112) - Doesn't Occur On Win32 Apprunner (1999111108) Linux Apprunner (1999111108) * CONFIGURATIONS TESTED - [Mac] Beige Power Mac G3 (266 MHz PowerPC 750), 96 MB RAM (VM on; 1 MB of VM used), 1024x768 (Thousands of Colors), Mac OS 8.6 - [Win32] Vectra VL (233 MHz P2), 96 MB RAM, 800x600 (True Color), NT 4.0 SP5. - [Linux] Vectra VL (266 MHz P2), 96 MB RAM. Red Hat Linux 6.0 (GNOME).
QA Contact: claudius → elig
QA Assigning to self to minimize claudius's bug load.
Assignee: davidm → don
reassign to don since I don't know who is responsible for the status bar. I think the easiest solution is to just move that text over. The harder solution would to figure out how add a box to represent the grow box.
Assignee: don → law
Target Milestone: M13
Bill, do want this one or do you need help from David?
Assignee: law → matt
This seems more like a style-sheet kind of change so I'm going to try to reassign it to Matt.
Target Milestone: M13 → M15
Worry about this later ...
Keywords: pp
Moving all UE/UI bugs to new component: User Interface: Design Feedback UE/UI component will be deleted.
Component: UE/UI → User Interface: Design Feedback
Summary: [PP] Last two digits of Build ID obscured by minimized Taskbar → Last two digits of Build ID obscured by minimized Taskbar
this was fixed awhile ago
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I know I'm not the QA here but this wasn't really 'fixed'. The little lock(security icon) was placed to the right of the build id. So instead of the build id this icon is obscured. Basically it needs to be decided if we're going to leave 15px of space to the right of whatever the last widget in that space is to accommodate the Mac's growbox.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
sorry, i thought this happened on every platform but the mac.
Move to M16 for now ...
Target Milestone: M15 → M16
*** Bug 32503 has been marked as a duplicate of this bug. ***
Size box no longer overlaps with the build id. Instead, it overlaps with the security indicator.
Target Milestone: M16 → M18
It just occurred to me that this is not a trivial issue (now). The Macintosh UI grow box (lower right corner of window) can obsure the security lock icon, when the bottom taskbar is collapsed. This means that the user has no visual indication of SSL status, nor an icon with which to invoke the PSM dialogs. Nominating for nsbeta2, noting that this would fail the daily smoketest if the collapsed state for the taskbar were the default configuration of the browser.
Assignee: matt → ben
Severity: trivial → normal
Status: REOPENED → NEW
Keywords: nsbeta2
updating title.
Summary: Last two digits of Build ID obscured by minimized Taskbar → Mac 'grow box' can overlap and hide security indicator (lock icon)
[nsbeta2-] since few users are expected to collapse or hide the taskbar.
Whiteboard: [nsbeta2-]
Move to M20 target milestone.
Target Milestone: M18 → M20
taking bug from Ben
Assignee: ben → pchen
Status: NEW → ASSIGNED
Affects Mac Classic theme, too.
Implementing the suggestionin bug 48840 would solve this problem.
UI/DF: taking QA. To imagine that few users will hide the taskbar, in its current uselessness, is wishful thinking IMO. And if the taskbar is hidden, you have no indication at all as to the security status of the page (whereas before you had the toolbar icon as well). That's pretty serious.
Keywords: nsbeta3
QA Contact: elig → mpt
Whiteboard: [nsbeta2-] → [nsbeta2-][NEED INFO]
Paul, how serious is this? And how hard is it to fix?
How serious it is depends on how important it is for a user to know whether a document is secure or not. It is quite easy to fix: just add an empty 16-pixel-wide box to the right of the lock icon in the status bar, to take the space which would be covered by the sizing box.
An additional box isn't really needed. Increasing the icon's margin-right by 16px would be sufficent. This could be done statically (very easy, no XUL change, virtually no risk, would look a bit weird with the Taskbar enabled) or dynamically via the DOM depending on the visibility of the Taskbar.
The reason I suggested an additional box was that it would be more forwards-compatible with future changes to the layout of the status bar (e.g. if the lock icon was moved). Raising to Major, because not knowing whether you are in a secure area or not seems to me to be pretty serious.
Severity: normal → major
am I missing something here? I can see the security icon just fine on the 2000092212 build on MacOS with the taskbar turned off. If I shrink the window, yes it eventually is not visible once the window goes below whatever the min-width is, but surely that's not what this bug is about?
Bug reproduced with 2000092212 build, Mac OS 9.0. The lock icon is hidden exactly as shown in the screenshot I have attached -- no matter what the window size is.
Oh duh. this is classic only. The lock icon is just fine on the modern skin. makes me believe the fix shouldn't be too difficult. adding classic and rtm keywords. Yes I know I should be flogged for using modern on the Mac, but my eyes don't see skins, I just see the browser underneath :-)
Keywords: classic, rtm
Marking this "rtm-". Since this only happens if you hide the taskbar, which is probably unlikely for most users, I'm not holding RTM for this.
Assignee: pchen → ben
Status: ASSIGNED → NEW
Whiteboard: [nsbeta2-][NEED INFO] → [nsbeta2-][rtm-]
Oh well... Nominating for Mozilla 0.9 then.
Keywords: mozilla0.9
-> andreww
Assignee: ben → andreww
accepting.
Status: NEW → ASSIGNED
Ok I can replicate this. Looks like the lock needs the additional margin space.
Summary: Mac 'grow box' can overlap and hide security indicator (lock icon) → [Classic]Mac 'grow box' can overlap and hide security indicator (lock icon)
Ok, found the icon and added the margin-right. It works like a charm. Ready to check in as soon as I can get a reviewer, etc.
Note that this should also be done for Windows Classic in preparation for bug 27795.
Priority: P3 → P1
simple enough... r=hewitt
a=hangas
setting milestone
Target Milestone: --- → mozilla0.9
setting _right_ milestone.
Target Milestone: mozilla0.9 → mozilla0.8
fixed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
Chaning the qa contact on these bugs to me. MPT will be moving to the owner of this component shortly. I would like to thank him for all his hard work as he moves roles in mozilla.org...Yada, Yada, Yada...
QA Contact: mpt → zach
I don't know about mac, but we don't want this fix on Windows or Linux. It results in an unsightly, noticeable space to the right of the security icon. I'd hate to have to make platform-specific securityOverlay.css's, but... In any event, I'm guessing this isn't an ideal fix for Mac either, since the icon will be pushed over even if the grow box wouldn't be covering it anyways, right? Not to mention that anything else that's ever put into the corner of any window with a grow box will be obscured.... I think, if possible, some toolkit work is needed here to make sure things stay away from the grow box. Alternatively, we could insert some faux box/element early on in place of the grow box so other nodes would know to reposition themselves (that's still hacky, but better imo...)
Status: RESOLVED → REOPENED
Keywords: nsbeta2, nsbeta3, rtm
Resolution: FIXED → ---
Whiteboard: [nsbeta2-][rtm-]
Blake I chatted with Ben who may have a solution to the issues you have with the current implementation and he recommended you file a new bug with those issues. However the bug that is listed here about the lock icon being obscured is indeed fixed since it isnt obscured any longer. The issue of the status bar in windows having empty space to the right is also something that could be filed separately. If you file the new bug on me Ill make sure I sync with Ben on his proposed changes. It looks like he's implementing a larger drag area in windows that corresponds to the growbox you see on the mac, and will be invisible on the mac. And looks like it would play the role of the additional box you were mentioning. Marking WORKSFORME and recommending that new lock placement issues be filed in a new bug. Re the empty space on windows classic (Modern already does this), the desire to add an addition box resizer, etc. etc.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → WORKSFORME
marking VERIFIED WFM to reduce spam but it is irksome that a bug went from fixed to WFM without anything actually happening.
Status: RESOLVED → VERIFIED
Component: User Interface Design → Browser-General
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: