1866716 - Remove Assertions.h from Atomics.h

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Gabriele Svelto [:gsvelto]]

I accidentally noticed that mfbt/Atomics.h includes mfbt/Assertions.h but doesn't use it, since both are widely used includes it's a good to remove this unneeded dependency.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1866716 - Remove unneeded headers from Atomics.h r=glandium

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1957c4453ab1
Remove unneeded headers from Atomics.h r=glandium,profiler-reviewers

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: WIP: Bug 1866716 - Fixup for WasiAtomic.h

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0745c3e29ba3
Fixup for WasiAtomic.h CLOSED TREE

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1957c4453ab1
https://hg.mozilla.org/mozilla-central/rev/0745c3e29ba3

Comment 6

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0745c3e29ba3
Fixup for WasiAtomic.h CLOSED TREE

== Change summary for alert #40467 (as of Thu, 30 Nov 2023 12:56:24 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
14%	motionmark_webgl 3DGraphics-WebGL	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	6.18 -> 7.06

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40467

Comment 7

[Mayank Bansal]

(In reply to Andrej (:aglavic) from comment #6)

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0745c3e29ba3
Fixup for WasiAtomic.h CLOSED TREE

== Change summary for alert #40467 (as of Thu, 30 Nov 2023 12:56:24 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
14%	motionmark_webgl 3DGraphics-WebGL	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	6.18 -> 7.06

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40467

It says that this alert is reassigned to https://treeherder.mozilla.org/perfherder/alerts?id=40473 , which points out bug 1862309.

Comment 8

[Andrej (:aglavic)]

You're right it looks as if I've attached it to this bug by accident, my apologies, let me remove references to this bug to reduce confusion