1866732 - Remove support for loading JSMs in Actors

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task)

Description

[Mark Banner (:standard8)]

Once bug 1866720 has landed, I think we will have no more actors in m-c that use JSMs - except for tests which are explicit checking that the JSMs load into actors.

Bug 1866725 is the equivalent for comm-central code.

Hence, once they are landed/complete, we should be able to remove the actor support for loading JSMs.

Comment 1

[Mark Banner (:standard8)]

Mathew: We did want this to depend on bug 1866725 being complete. This was a big change and we wanted to give Thunderbird time to complete it (which they now have). Although we don't always wait on Thunderbird, this was an explicit choice as mentioned in comment 0. Please stop unnecessarily changing dependencies.

Comment 2

[Andrew McCreight [:mccr8]]

standard8, do you think it would be okay to do this now? It looks like the two dependent bugs landed about 7 months ago.

Comment 3

[Andrew McCreight [:mccr8]]

The see also bug 1881887 says that they were waiting for ESR128, and we're on 130 in Nightly now.

Comment 4

[Mark Banner (:standard8)]

The last published plan for removing the import support following ESM-ification was Firefox 136.

However, I'm not sure if we had any external code using actors, so it may be possible that we could clean up the actors, especially if that's blocking other work.

I'm going to pass this over to :arai though, as they have more of an insight into the external factors than I do.

Comment 5

[Tooru Fujisawa [:arai]]

There are some external consumers for actors API, and at least 2 of them are not yet fully ESMified.

Most of the data for Thunderbird extensions are from 6 month ago (except for the following 2 that I checked right now), I can check the latest data from Thunderbird addons website if necessary. (only public addons)

For Firefox privileged extensions, I don't have enough privileges to check all of them, but at least for public ones, the following is the only consumer.

Firefox privileged extensions:

• https://github.com/mozilla-extensions/china-newtab/blob/develop/extension/mozillaonline/parent/ext-chinaNewtab.jsn (partially ESMified)

Thunderbird extensions:

• https://addons.thunderbird.net/en-US/thunderbird/addon/birthday-calendar/ (not ESMified)
• https://addons.thunderbird.net/en-us/thunderbird/addon/owl-for-exchange/ (already ESMified)

Comment 6

[Andrew McCreight [:mccr8]]

Thanks. It isn't getting in the way of anything I'm working on, but I was looking at this code and I figured I'd clean it up if it was completely unused. But it sounds like it is not.

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1866732 - Part 1: Remove tests for loading JSMs in Actors. r?nika!

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1866732 - Part 2: Remove support for loading JSMs in Actors. r?nika!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/682921dba76d
Part 1: Remove tests for loading JSMs in Actors. r=nika
https://hg.mozilla.org/integration/autoland/rev/17e232b2bc28
Part 2: Remove support for loading JSMs in Actors. r=nika

Comment 10

[amarc]

Backed out for causing xpcshell failures @ test_envChain_subscript_in_frameScript.js

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | js/xpconnect/tests/unit/test_envChain_subscript_in_frameScript.js | xpcshell return code: 0

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c08a7d532dd8
Part 1: Remove tests for loading JSMs in Actors. r=nika
https://hg.mozilla.org/integration/autoland/rev/9a7d899876be
Part 2: Remove support for loading JSMs in Actors. r=nika

Comment 12

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c08a7d532dd8
https://hg.mozilla.org/mozilla-central/rev/9a7d899876be