1866811 - the javascript-engine returns 943916400000 on Date.parse("0000-00-00") instead of NaN

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[m.sekora.ca]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

run Date.parse("0000-00-00") in the Javascript-Console

Actual results:

943916400000

Expected results:

NaN

Comment 1

[Vinny Diehl]

Attachment: Bug 1866811 - Reject numeric dates with 0 for mon or mday r?arai

Comment 2

[Vinny Diehl]

Thanks for the referral, Tom! TryParseDashedNumericDatePrefix needed to be tightened up a little bit, I have a patch up.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35576b9194fb
Reject numeric dates with 0 for mon or mday r=arai

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/35576b9194fb

Comment 5

[Thorin [:thorin]]

FF120 + 121 affected

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:vinny.diehl, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Vinny Diehl]

Do you think we should uplift this? Asking because of priority set, and because this format YYYY-mm-dd is similar to spec format. Not sure if any websites might rely on this being NaN.

Comment 8

[Tooru Fujisawa [:arai]]

So, this is a kind of regression from bug 1557650.
I think beta uplift makes sense.

Comment 9

[Vinny Diehl]

Attachment: Bug 1866811 - Reject numeric dates with 0 for mon or mday

Original Revision: https://phabricator.services.mozilla.com/D194858

Comment 10

[Phabricator Automation]

Uplift Approval Request

• String changes made/needed: None
• Needs manual QE test: no
• Risk associated with taking this patch: Low
• Fix verified in Nightly: yes
• User impact if declined: Regression affecting date parsing of invalid ISO-like format which is rejected by other browsers
• Explanation of risk level: Small change in well-tested code
• Steps to reproduce for manual QE testing: Date.parse("0000-00-00") should be NaN
• Code covered by automated testing: yes
• Is Android affected?: yes

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366399 [details]
Bug 1866811 - Reject numeric dates with 0 for mon or mday

Approved for 121.0b6.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/186477afbdb4