1866829 - Allow PGO build on Python 3.12

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[[:sergesanspaille]]

It currently fails due to references to the now removed distutils package.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1866829 - Replace obsolete distutils reference by portable alternatives r=ahochheiden!

distutils.dir_util.copy_tree -> shutil.copytree
distutils.spawn.find_executable -> shutil.which

Also fix a warning about escape sequence in the process.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d5bb9ef15c7
Replace obsolete distutils reference by portable alternatives r=ahochheiden

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing mass failures on Android.

• Backout link
• Push with failures
• Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2de51d702554
Replace obsolete distutils reference by portable alternatives r=ahochheiden

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing mass failures on Android

Backout link

Push with failures

Failure log

Comment 6

[[:sergesanspaille]]

Hell, the dir_exists_ok keyword argument is only available since py 3.8, let me check if I can enforce this, as we're already moving to py3.8

Comment 7

[Mike Hommey [:glandium]]

(In reply to [:sergesanspaille] from comment #6)

Hell, the dir_exists_ok keyword argument is only available since py 3.8, let me check if I can enforce this, as we're already moving to py3.8

That hasn't landed yet. You'll have to wait for bug 1843209.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:sergesanspaille, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 9

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Bug 1843209 landed and hasn't been backed out in over a week, so I'd say you're good to go with dir_exists_ok :sergesanspaille.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6af7194e2778
Replace obsolete distutils reference by portable alternatives r=ahochheiden

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/6af7194e2778