1866930 - Firefox fails WPT css/css-grid/subgrid/orthogonal-writing-mode-005.html

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect)

Description

[Thomas Wisniewski [:twisniewski]]

+++ This bug was initially created as a clone of Bug #1841299 +++

wpt.fyi:
https://wpt.fyi/results/css/css-grid/subgrid/orthogonal-writing-mode-005.html

Comment 1

[Jonathan Kew [:jfkthame]]

Looks like this was recently fixed in Blink; would be good if we could also resolve it.

Comment 2

[Daniel Holbert [:dholbert]]

There's some analysis of this test to explain the updated expectations (and what Firefox/Chrome have been doing incorrectly) in the CSSWG issue here: https://github.com/w3c/csswg-drafts/issues/9418

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: reduced testcase 1

Our test failures here are all in the "named grid areas" section at the far right end of the WPT test.

Here's a reduced testcase with just that section.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: reduced reference case 1

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1866930 - Swap logical axes when inheriting line names in an orthogonal subgrid. r=#layout

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6f2ae8ac3d5d
https://hg.mozilla.org/integration/autoland/rev/6db1a0c5a850
Swap logical axes when inheriting line names in an orthogonal subgrid. r=layout-reviewers,emilio

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/6db1a0c5a850

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1866930 - Swap logical axes when inheriting line names in an orthogonal subgrid.

Original Revision: https://phabricator.services.mozilla.com/D279143

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1866930 - Swap logical axes when inheriting line names in an orthogonal subgrid.

Original Revision: https://phabricator.services.mozilla.com/D279143

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/3e9aa1b9dab9
https://hg.mozilla.org/releases/mozilla-beta/rev/def0f7b699f2

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/1a60aae40003
https://hg.mozilla.org/releases/mozilla-release/rev/f47a8b2c68a5