1866939 - ZoomToFocusInput doesn't work in some cases in OOP iframes

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

data:text/html,<iframe src="https://hiikezoe.github.io/input.html" style="margin-top:2000px">
data:text/html,<iframe src="https://hiikezoe.github.io/input.html?margin-top=2000px">

In above cases ZoomToFocusInput doesn't work properly. I suppose it's due to the lack of the top level document layout scroll offset translation as Botond pointed out.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

With the scroll offset, this targetRect can be same as non Fission case, but still there's something wrong. Zooming-in doesn't happen at all.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1866939 - Apply the root APZC's scroll offset in GetOopifToRootContentTransform(). r?botond

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1866939 - Offset the in-process root frame scroll position layout in nsDOMWindowUtils::ZoomToFocusedInput(). r?botond

See the reason [1] in GetBoundingContentRect in DoubleTapToZoom.cpp.

[1] https://searchfox.org/mozilla-central/rev/f170bc26fdcfda53a270dc4f257202e62f4b781f/gfx/layers/apz/util/DoubleTapToZoom.cpp#138-143

Depends on D197259

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fb1b891307b
Apply the root APZC's scroll offset in GetOopifToRootContentTransform(). r=botond
https://hg.mozilla.org/integration/autoland/rev/b0542bbe1fe7
Offset the in-process root frame scroll position layout in nsDOMWindowUtils::ZoomToFocusedInput(). r=botond

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6fb1b891307b
https://hg.mozilla.org/mozilla-central/rev/b0542bbe1fe7

Comment 6

[Cristina Horotan [:chorotan]]

Backed out: https://hg.mozilla.org/integration/autoland/rev/78eeb3123fa6e20a69df1262937ffa372b2a47d5

Comment 7

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/78eeb3123fa6

Comment 8

[Hiroyuki Ikezoe (:hiro)]

There were two different causes of the test failure.

1. bug 1875211
2. I forgot setting layout.scroll.disable-pixel-alignment

I am not sure about 2 though, it may not be related. The main cause is 1 anyway.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f47aba128d29
Apply the root APZC's scroll offset in GetOopifToRootContentTransform(). r=botond
https://hg.mozilla.org/integration/autoland/rev/2775f61c6182
Offset the in-process root frame scroll position layout in nsDOMWindowUtils::ZoomToFocusedInput(). r=botond

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f47aba128d29
https://hg.mozilla.org/mozilla-central/rev/2775f61c6182