1866992 - Add adsExposure & noAdsAvailable telemetry probes

Status: VERIFIED FIXED

(Fenix :: Shopping, task, P1)

Description

[Vlad Dreghici [:vdreghici]]

According to this sheet we are still missing the adsExposure and noAdsAvailable probes.

Comment 1

[Vlad Dreghici [:vdreghici]]

The ads exposure events are needed for the execution of the ads experiment. The primary comparison of interest is “users who saw ads vs users who could’ve seen ads” and the telemetry is necessary to determine that 2nd population. Because it’s needed for the execution of the experiment, it is also needed to plan the experiment (sizing).

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1866992 - Add product recommendations exposure telemetry (#4622)

Comment 3

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/daf7931aee0e24763e302203ddf36b6a8e434d8a
[main] Bug 1866992 - Add product recommendations exposure telemetry

Comment 4

[miralobontiu]

Verified on the latest Fenix Nightly 122.0a1 from 11/29, and the following evenst were triggered:

 "timestamp": 1437,
"category": "shopping",
"name": "ads_exposure"

"timestamp": 5761,
"category": "shopping",
"name": "surface_no_ads_available"

Glean dashboard

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1866992 - Add product recommendations exposure telemetry (backport #4622) (#4636)

Comment 6

[Rahul Sainani [:rsainani]]

Comment on attachment 9366041 [details] [review]
[mozilla-mobile/firefox-android] Bug 1866992 - Add product recommendations exposure telemetry (backport #4622) (#4636)

Beta/Release Uplift Approval Request

• User impact if declined: The ads exposure events are needed for the execution of the ads experiment. The primary comparison of interest is “users who saw ads vs users who could’ve seen ads” and the telemetry is necessary to determine that 2nd population. Because it’s needed for the execution of the experiment, it is also needed to plan the experiment (sizing).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Mentioned in the bug description
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Since this is adding 2 telemetry events and the logic is very well covered with unit tests it's a low risk change. But since the lines of code changes are bit higher, I'm being cautious in labeling the risk as medium.
• String changes made/needed: no
• Is Android affected?: Yes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366041 [details] [review]
[mozilla-mobile/firefox-android] Bug 1866992 - Add product recommendations exposure telemetry (backport #4622) (#4636)

Approved for 121.0b6.

Comment 8

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/144b8c3a540e21e2652b782ee2e9deae68ce720a
[releases_v121] Bug 1866992 - Add product recommendations exposure telemetry

Comment 9

[Margareta Eliza Ciure]

Verified as fixed on Firefox Beta 121.0b6 with Samsung Galaxy S23 Ultra (Android 13) and Motorola G9 plus (Android 11).