1867057 - The Adjusted ratings card is displayed for unknown products

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: 2023-11-28_16h56_04.png

Found in

• Nightly 122.0a1 (2023-11-27)

Affected versions

• Nightly 122.0a1 (2023-11-27)

Affected platforms

• ALL

Preconditions:
browser.shopping.experience2023.enabled - true
browser.shopping.experience2023.optedIn = 0

Steps to reproduce

1. Reach https://www.amazon.de/Amazon-brand-Movian-computer-drawers/product-reviews/B07GFRCZWY/ref=cm_cr_arp_d_paging_btm_next_2?ie=UTF8&reviewerType=all_reviews&pageNumber=2

Expected result

• We should not get a product_id for unknown products : https://searchfox.org/mozilla-central/rev/9bc264fbc5d6e618d8f3b9677a8f5e8550b94dbc/browser/components/shopping/content/shopping-container.mjs#217,224-225

Actual result

• The Product page showed an unanalyzed card, after which the Not enough reviews message was displayed and finally after refresh the Adjusted card is displayed with 0 stars.

Regression range
Not Applicable

This is a new Feature that brings Shopping support to amazon.fr and amazon.de.

Comment 1

[Fred Chasen [:fchasen]]

Attachment: Bug 1867057 - Check ifDefined when setting rating for AdjustedRating component. r=#shopping-reviewers

Prevent null from being coerced into 0 for the rating.

Comment 2

[Fred Chasen [:fchasen]]

Attachment: Bug 1867057 - Display unanalyzed product card if analysis grade is missing. r=#shopping-reviewers

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Marking as a P1, since it's assigned

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

...and bumping up the severity, since this is a very noticeable bug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b4191b2f470
Check ifDefined when setting rating for AdjustedRating component. r=shopping-reviewers,Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2b377eea84f
Display unanalyzed product card if analysis grade is missing. r=shopping-reviewers,Gijs

Comment 7

[Cristian Tuns]

Backed out for causing bc failures in browser_inprogress_analysis.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_inprogress_analysis.js | Got stale message-bar - "undefined" == "stale" - got (void 0), expected "stale" (operator ==)

Comment 8

[Fred Chasen [:fchasen]]

Updated to check that grade is a "string" instead of "number".

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/184994c096de
Display unanalyzed product card if analysis grade is missing. r=shopping-reviewers,Gijs

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5b4191b2f470
https://hg.mozilla.org/mozilla-central/rev/184994c096de

Comment 11

[Rares Doghi, Desktop QA]

Tested with our latest Nightly build 122.0a1 (2023-12-05) using this URL : https://www.amazon.com/Energizer-Headlamp-Resistant-Headlamps-Batteries/dp/B0CDJFFD8S/ref=sr_1_48?crid=296KJTHQVWMW6&keywords=headlamp&qid=1701795545&sprefix=headlamp%2Caps%2C91&sr=8-48

It now correctly shows the un-analyzed card, unless someone hits the Check Review Quality button the url should be good to test this issue.