Closed
Bug 186720
Opened 22 years ago
Closed 22 years ago
xmlterm NewURI should throw instead of returning null
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: hamfastgamgee)
References
()
Details
Attachments
(1 file)
|
740 bytes,
patch
|
timeless
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
this is a contract violation and the result can be a crash.
|
Assignee | |
Comment 1•22 years ago
|
||
Turns out none of the other callers of .newURI in Javascript check for this
case, so it would seem that failure is not an option here. Removing the check,
per timeless's investigation.
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•22 years ago
|
||
You would think accepting a bug would reassign it to you.... Oh well.... :)
Assignee: timeless → andersma
Status: ASSIGNED → NEW
Attachment #110157 -
Flags: superreview?(darin)
Attachment #110157 -
Flags: review?(darin)
Attachment #110157 -
Flags: review?(darin) → review+
|
||
Comment 3•22 years ago
|
||
Comment on attachment 110157 [details] [diff] [review]
Patch to fix this issue
sr=darin (yeah, it is common and certainly not invalid to ignore aBaseURI if
one is not expected.)
Attachment #110157 -
Flags: superreview?(darin) → superreview+
|
|
Assignee | |
Comment 4•22 years ago
|
||
timeless checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•