186726 - Icon protocol handler NewURI should use NS_ADDREF

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[timeless]

at this point, it is known to be non null.

Comment 1

[Mark Anderson]

Attachment: Patch for the issue

This patch fixes the issue mentioned and also adds a check to see if SetSpec
has failed or not.

Comment 2

[Mark Anderson]

Taking....

Comment 3

[Darin Fisher]

Comment on attachment 110161 [details] [diff] [review]
Patch for the issue

>Index: icon/nsIconProtocolHandler.cpp

>   if (!uri) return NS_ERROR_FAILURE;

>+  if (NS_FAILED(rv))
>+    return rv;

nit, no newline for consistency:
    if (NS_FAILED(rv)) return rv;


>   *result = uri;
>+  NS_ADDREF(*result);

nit, combine these two lines:
    NS_ADDREF(*result = uri);


sr=darin (w/ or w/o suggested changes)

Comment 4

[Mark Anderson]

Attachment: Patch revised for darin's comments

Comment 5

[Mark Anderson]

timeless checked in.