1867330 - [wpt-sync] Sync PR 43422 - Revert "Check if math expression has percentages deep inside"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43422 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43422
Details from upstream follow.

David Baron <[e-mail]> wrote:

Revert "Check if math expression has percentages deep inside"

This reverts commit fc365dddd74a2c9ba22036fd5563dbea8ff34c7c.

Reason for revert: failures of external/wpt/css/css-values/signs-abs-computed.html on at least https://ci.chromium.org/ui/p/chromium/builders/ci/mac13-arm64-rel-tests/10874/test-results

Original change's description:

Check if math expression has percentages deep inside

Currently, only the top level category is checked to have a percentage
dependency, check all the nodes inside the expression as well,
as it can be the case like:
NumberProducingFunction(Percentage) * Pixels.
The top level category is Length in such case and we try to resolve it
with ComputeLength, where percentages are not allowed.

Note: the added test would crash before the CL, as it would try to
GetDouble() of percentage which is not allowed in that context.

Bug: 1505817
Change-Id: Iefd13c0d190c3b8adf463ea244f81331635e14fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5064155
Commit-Queue: Daniil Sakhapov \<[e-mail]>
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1230671}

Bug: 1505817
Change-Id: I8ce6bd91c3b69cdbb6036d3ad73b08c200447ea7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/5070884
WPT-Export-Revision: 3ea1c4b73752625c53bf4ec9e7302adfb057bb30

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee7a763049d5
[wpt PR 43422] - Revert "Check if math expression has percentages deep inside", a=testonly

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b673d559f0d
[wpt PR 43422] - Revert "Check if math expression has percentages deep inside", a=testonly

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9b673d559f0d