Closed Bug 1867340 Opened 2 years ago Closed 2 years ago

Enable the new WindowsJumpList backend by default held to Nightly

Categories

(Firefox :: Shell Integration, task)

Product:
Firefox
Component:
Shell Integration
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file)

Bug 1867340 - Enable the new Windows Jump List backend on Nightly only. r?mhowell
48 bytes, text/x-phabricator-request
Details | Review

I've been testing this manually for a few days and it seems to do the trick, so I'd like to enable it more widely for our Nightly audience.

Assignee: nobody → mconley
Status: NEW → ASSIGNED

Because the bot didn't comment when the patch landed on autoland I will leave this message with the revision from autoland:
https://hg.mozilla.org/integration/autoland/rev/092ba04f942511005e90f42f6ae7e8d74d3b9f41

Backed out for causing failures due to WindowsJumpLists.sys.mjs

[task 2023-11-30T02:03:41.094Z] 02:03:41     INFO - TEST-PASS | browser/base/content/test/protectionsUI/browser_protectionsUI_telemetry.js | Adds one more instance of the shield being shown - 
[task 2023-11-30T02:03:41.094Z] 02:03:41     INFO - Buffered messages finished
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/protectionsUI/browser_protectionsUI_telemetry.js | A promise chain failed to handle a rejection: [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "<unknown>"  data: no] - stack: buildList@resource:///modules/WindowsJumpLists.sys.mjs:283:3
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - async*WTBJL_update@resource:///modules/WindowsJumpLists.sys.mjs:672:25
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - WTBJL_notify/<@resource:///modules/WindowsJumpLists.sys.mjs:820:12
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - Rejection date: Thu Nov 30 2023 02:03:40 GMT+0000 (Coordinated Universal Time) - false == true - {"filename":"resource://testing-common/PromiseTestUtils.sys.mjs","name":"assertNoUncaughtRejections","sourceId":599,"lineNumber":266,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"handleTask","sourceId":567,"lineNumber":1166,"columnNumber":22,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"_runTaskBasedTest","sourceId":567,"lineNumber":1210,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":567,"lineNumber":1352,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":567,"lineNumber":1127,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":590,"lineNumber":1058,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"async*_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"handleTask@chrome://mochikit/content/browser-test.js:1166:22\nasync*_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"assertNoUncaughtRejections@resource://testing-common/PromiseTestUtils.sys.mjs:266:14\nhandleTask@chrome://mochikit/content/browser-test.js:1166:22\nasync*_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}}
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - Stack trace:
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - resource://testing-common/PromiseTestUtils.sys.mjs:assertNoUncaughtRejections:266
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - chrome://mochikit/content/browser-test.js:handleTask:1166
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1210
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1352
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1127
[task 2023-11-30T02:03:41.100Z] 02:03:41     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2023-11-30T02:03:41.101Z] 02:03:41     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/protectionsUI/browser_protectionsUI_telemetry.js | A promise chain failed to handle a rejection: [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "<unknown>"  data: no] - stack: buildList@resource:///modules/WindowsJumpLists.sys.mjs:283:3
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - async*WTBJL_update@resource:///modules/WindowsJumpLists.sys.mjs:666:21
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - WTBJL_notify/<@resource:///modules/WindowsJumpLists.sys.mjs:820:12
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - Rejection date: Thu Nov 30 2023 02:03:40 GMT+0000 (Coordinated Universal Time) - false == true - {"filename":"resource://testing-common/PromiseTestUtils.sys.mjs","name":"assertNoUncaughtRejections","sourceId":599,"lineNumber":266,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"handleTask","sourceId":567,"lineNumber":1166,"columnNumber":22,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"_runTaskBasedTest","sourceId":567,"lineNumber":1210,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":567,"lineNumber":1352,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":567,"lineNumber":1127,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":590,"lineNumber":1058,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"async*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"async*_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"handleTask@chrome://mochikit/content/browser-test.js:1166:22\nasync*_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}},"formattedStack":"assertNoUncaughtRejections@resource://testing-common/PromiseTestUtils.sys.mjs:266:14\nhandleTask@chrome://mochikit/content/browser-test.js:1166:22\nasync*_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1210:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1352:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1127:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13\n","nativeSavedFrame":{}}
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - Stack trace:
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - resource://testing-common/PromiseTestUtils.sys.mjs:assertNoUncaughtRejections:266
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - chrome://mochikit/content/browser-test.js:handleTask:1166
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1210
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1352
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1127
[task 2023-11-30T02:03:41.106Z] 02:03:41     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2023-11-30T02:03:41.107Z] 02:03:41     INFO - Leaving test bound testShieldHistogram
[task 2023-11-30T02:03:41.107Z] 02:03:41     INFO - Console message: [JavaScript Warning: "The resource at http://trackertest.org/ was blocked because content blocking is enabled." {file: "http://tracking.example.org/browser/browser/base/content/test/protectionsUI/trackingPage.html" line: 0}]
[task 2023-11-30T02:03:41.291Z] 02:03:41     INFO - GECKO(7880) | MEMORY STAT | vsize 2120818MB | vsizeMaxContiguous 65594235MB | residentFast 367MB | heapAllocated 143MB
[task 2023-11-30T02:03:41.291Z] 02:03:41     INFO - TEST-OK | browser/base/content/test/protectionsUI/browser_protectionsUI_telemetry.js | took 1262ms
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ecdeac40b04f Enable the new Windows Jump List backend on Nightly only. r=mhowell

https://hg.mozilla.org/mozilla-central/rev/ecdeac40b04f

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
Flags: needinfo?(mconley)
No longer blocks: 1877174
See Also: → 1877174
Blocks: 1880082
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: