1867346 - Tweak strings for ASRouter spotlight message to encourage users without FxA accounts to create one

Status: RESOLVED FIXED

(Firefox :: Messaging System, task)

Description

[Mike Conley (:mconley) (:⚙️)]

There's been a last minute change to one of the strings that we landed in bug 1866295.

Rather than the "Hoping for a new device this season?" string, we're hoping to reuse an older string, "New device in your future?" from here: https://searchfox.org/mozilla-central/rev/12ea2c521cdd071a6d25b0894f31f8f23b18b76a/browser/locales/en-US/browser/newtab/asrouter.ftl#223

This bug is for writing a patch that replaces the "Hoping for a new device this season?" string with the "New device in your future?" string.

I think I can do this without bumping the key because I don't believe any of these strings have been sent off for localization yet, but hopefully someone from the Fluent reviewers group can confirm.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1867346 - Tweak strings for ASRouter spotlight message to encourage users without FxA accounts to create one. r?#fluent-reviewers!

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #0)

I think I can do this without bumping the key because I don't believe any of these strings have been sent off for localization yet, but hopefully someone from the Fluent reviewers group can confirm.

Not only the strings have been exposed, we asked localizers to prioritize them
https://transvision.flod.org/string/?entity=browser/browser/newtab/asrouter.ftl:device-migration-fxa-spotlight-getting-new-device-header&repo=gecko_strings

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Ooof, apologies. :/ Well, correct me if I'm wrong, I guess we're not adding more work here, rather we're deprioritizing one of the strings in favour of a migration from an older string.

Should we still do a Fluent key bump here?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Ah, and I see that you answered that question in Phabricator already.

Comment 5

[Iulian Moraru]

Because the bot didn't comment when the patch landed on autoland I will leave this message with the revision from autoland:
https://hg.mozilla.org/integration/autoland/rev/d3c709f4051485466b4a67b327ecdf0540c4ece7

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d3c709f40514

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1867346 - Tweak strings for ASRouter spotlight message to encourage users without FxA accounts to create one.

Original Revision: https://phabricator.services.mozilla.com/D195013

Comment 8

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: no
• String changes made/needed: Yes, 100%.
• Risk associated with taking this patch: None.
• Fix verified in Nightly: no
• User impact if declined: Users on the 115 ESR channel will receive ASRouter messages for device migration that is tonally tied to the holiday season rather than being more general.
• Steps to reproduce for manual QE testing: N/A
• Explanation of risk level: This is just strings.
• Code covered by automated testing: no
• Is Android affected?: no

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9366303 [details]
Bug 1867346 - Tweak strings for ASRouter spotlight message to encourage users without FxA accounts to create one.

Approved for 115.7esr.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/f55d7baa02d5