1867418 - Investigate failing WPT minmax-length-percent-serialize.html (due to a test change which was later reverted)

Status: RESOLVED INVALID

(Core :: CSS Parsing and Computation, defect)

Description

[Thomas Wisniewski [:twisniewski]]

See https://wpt.fyi/results/css/css-values/minmax-length-percent-serialize.html

We're failing these 2 tests:

'max((min(10%, 30px) + 10px) * 2 + 10px, 5em + 5%)' as a specified value should serialize as 'max(10px + (10px + min(10%, 30px)) * 2, 5% + 5em)'.
'max((min(10%, 30px) + 10px) * 2 + 10px, 5em + 5%)' as a computed value should serialize as 'max(10px + (10px + min(10%, 30px)) * 2, 5% + 80px)'.

The failures are:

!EQ("max(10px + (10px + min(10%, 30px)) * 2, 5% + 5em)",
    "max(10px + ((10px + min(10%, 30px)) * 2), 5% + 5em)")
!EQ("max(10px + (10px + min(10%, 30px)) * 2, 5% + 80px)",
    "max(10px + ((10px + min(10%, 30px)) * 2), 5% + 80px)")

Comment 1

[Emilio Cobos Álvarez [:emilio]]

This is invalid. We're adding parenthesis around the product node but that's what the spec says to do, see https://github.com/web-platform-tests/wpt/pull/43364#issuecomment-1836461822

Comment 2

[Daniel Holbert [:dholbert]]

Our failure here was due to a recent test change, which was reverted in response to Emilio's comment on the pull request that he linked in comment 1 here.

Since the change was reverted, we're currently at 100% passing on https://wpt.fyi/results/css/css-values/minmax-length-percent-serialize.html so there's nothing more to do here.

Calling INVALID per comment 1, and adjusting summary to clarify.